Hello,

LGTM

Hi, Sergey!
Thanks for the review!

On 13.12.24, Sergey Bronnikov wrote:

Hello, Sergey,

thanks for the patch! LGTM with a minor comment.

On 11.12.2024 16:21, Sergey Kaplun wrote:

From: Mike Pall <mike>

(cherry picked from commit de6b1a11dd1a3349179084578c5d533be1c30234)

Before this patch, Valgrind produces tons of warnings during the VMevent
calls since the `IR_NOP` instruction isn't fully initialized. Hence, any
parsing operations for it in handlers during `jit.dump()` leads to the
"uninitialised value" error. This patch fixes the issue by the proper
init of such IRs.

Please add to a comment that with these tests the problem could

  be reproduced:

test/tarantool-tests/lj-1128-table-new-opt-tnew.test.lua

test/tarantool-tests/fix-jit-dump-ir-conv.test.lua

test/tarantool-tests/unit-jit-parse.test.lua

Updated. The new commit message is the following:

| Ensure full init of IR_NOP instructions.
|
| (cherry picked from commit de6b1a11dd1a3349179084578c5d533be1c30234)
|
| Before this patch, Valgrind produces tons of warnings during the VMevent
| calls since the `IR_NOP` instruction isn't fully initialized. Hence, any
| parsing operations for it in handlers during `jit.dump()` leads to the
| "uninitialised value" error.
|
| This can be reproduced with the following tests from the
| tarantool-tests suite:
| * fix-jit-dump-ir-conv.test.lua
| * lj-1128-table-new-opt-tnew.test.lua
| * lj-981-folding-0.test.lua
| * unit-jit-parse.test.lua
|
| This patch fixes the issue by the proper init of such IRs.
|
| Sergey Kaplun:
| * added the description for the problem
|
| Needed for tarantool/tarantool#3705
| Part of tarantool/tarantool#10709

Sergey Kaplun:
* added the description for the problem

Needed for tarantool/tarantool#3705
Part of tarantool/tarantool#10709
---

<snipped>