From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0221E2569A
	for <tarantool-patches@freelists.org>; Mon, 18 Jun 2018 17:03:56 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id NOeWPPSk9YRW for <tarantool-patches@freelists.org>;
	Mon, 18 Jun 2018 17:03:55 -0400 (EDT)
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B43A22567F
	for <tarantool-patches@freelists.org>; Mon, 18 Jun 2018 17:03:55 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH] sql: remove redundant goto from
 VDBE prologue
References: <20180612182607.53450-1-korablev@tarantool.org>
 <24a1a33e-02cc-ccf4-7ff9-a155f5e18781@tarantool.org>
 <28322F56-E52D-42C7-AE52-188D6F50AF63@tarantool.org>
 <5b137003-b3ea-918d-4528-a1c30712abd5@tarantool.org>
 <27FB91D4-8386-4AE9-8A1E-B68FE60EAB6B@tarantool.org>
 <b10cc995-3cbb-8ee2-3287-3833aeceab81@tarantool.org>
 <83377E01-A80A-41A3-ACD9-939DF6CD2910@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <c3fcb1d9-6910-db42-2c7d-c5549d3bf1b9@tarantool.org>
Date: Tue, 19 Jun 2018 00:03:52 +0300
MIME-Version: 1.0
In-Reply-To: <83377E01-A80A-41A3-ACD9-939DF6CD2910@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, "n.pettik" <korablev@tarantool.org>

Thanks. Now LGTM.

On 18/06/2018 23:55, n.pettik wrote:
> 
>>> Thx for refactoring, but it wouldn’t work this way:
>>> We must firstly make lable to jump (sqlite3VdbeJumpHere(v, 0);),
>>> then test on emitting OP_TTransaction and const exprs (or both). If we need to
>>> add such opcodes, then we should jump back. Otherwise, dismiss initial jump.
>>
>> We do not need to change P2 until it is really needed. That is what I
>> mean.
> 
> Ok, my apologies for misunderstanding. I pushed your changes.
>