From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 551D96EC5B; Tue, 30 Mar 2021 02:04:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 551D96EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617059089; bh=0+Vp7CCMqKTbO7EGtvgr2q2R2k3DjbiL7g93/yhCr5E=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=FdSYbyEaaQYe1p6nNbKUCrLwqlX5rcVMmYd+cXIOcJGuoIb5hxTe7UfBjKHd0sBLA me8fXtCSAmJvH5nBX3N+4O15KNCXYjKmtTjGyf5cbtQBlg+WlztHHKCb4ZeK4w/0dg xVx8lrTROsjOpUbK2vGqE60AlM/iEJWb1I+iGcOk= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 67E656BD01 for ; Tue, 30 Mar 2021 02:03:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 67E656BD01 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lR0ul-0000VR-M4; Tue, 30 Mar 2021 02:03:20 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <70ffab024b9c7066d833028ee4bd2b8e6db14c6c.1616491731.git.imeevma@gmail.com> Message-ID: Date: Tue, 30 Mar 2021 01:03:18 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <70ffab024b9c7066d833028ee4bd2b8e6db14c6c.1616491731.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4ABD7C98AF5DBFD37182A05F5380850405D852099F0F93F35A8274DC719220F881FD82C391CCB376BF600E77B53AAB791 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE723628CE20AC63995EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B84F9009663064BD8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFBAFF165445263698F515C5F7187F320DA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE709B92020B71E24959FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3A367EA73E0D98AAD117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735F409322A2F59C95CC4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831BA35FD678FCE4FDB86445F3BB20A73D6 X-C1DE0DAB: 0D63561A33F958A570ED5F0C7E98E1D540741D0E6B536B91F3CC0363CFE73E6ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344A431191C56981FEDD4334A5A2A74EA1321AD8653136B2ED8BE20BE47BFEC312BFF0FE35B4DC07C01D7E09C32AA3244C39781C7DB585CA26DA1F7912279D70537101BF96129E4011FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rTfCv1d9smfAw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382207EC1E6D7233B7FE7162490C0ED99D3D3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 20/53] sql: introduce mem_bitwise() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! On 23.03.2021 10:35, Mergen Imeev via Tarantool-patches wrote: > This patch introduces mem_bitwise(). Function mem_bitwise() executes > bitwise operations with two operands and writes the result to the third > MEM. > > Part of #5818 > --- > src/box/sql/mem.c | 51 +++++++++++++++++++++++++++++++++++++++++++ > src/box/sql/mem.h | 3 +++ > src/box/sql/vdbe.c | 54 +++------------------------------------------- > 3 files changed, 57 insertions(+), 51 deletions(-) > > diff --git a/src/box/sql/mem.c b/src/box/sql/mem.c > index 8119644ed..2b455e39f 100644 > --- a/src/box/sql/mem.c > +++ b/src/box/sql/mem.c > @@ -556,6 +556,57 @@ mem_arithmetic(const struct Mem *left, const struct Mem *right, > return 0; > } > > +int > +mem_bitwise(struct Mem *left, struct Mem *right, struct Mem *result, int op) Would be better to split it into separate functions. Also why is OP_BitNot separated? How is it much different from, say, OP_BitAnd? Besides, having OP_BitNot in mem.c would allow to make sqlVdbeIntValue static inside mem.c.