From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 83C8E469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 23 Nov 2020 17:44:26 +0300 (MSK)
References: <cover.1605629206.git.sergeyb@tarantool.org>
 <41492964d52aa46391a621e640f1ffc83bf5a0b0.1605629206.git.sergeyb@tarantool.org>
 <d5445975-3272-8597-0766-930171b01b3d@tarantool.org>
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <c2de21c8-1fc6-cdae-f688-7a9cc009437e@tarantool.org>
Date: Mon, 23 Nov 2020 17:44:25 +0300
MIME-Version: 1.0
In-Reply-To: <d5445975-3272-8597-0766-930171b01b3d@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH 1/4] replication: run
 clear_synchro_queue() with unconfigured box
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for review!

On 21.11.2020 17:41, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
>  From the commit title it seems like you introduced a feature to run
> the function with non-configured box. Please, change 'run' to 'test',
> would be better already.
>
> Also for qsync we usually write title 'qsync: ...', not just
> 'replication: ...'. Or in your case it could be 'test: ...',
> but up to you. The same for the other commits.

updated prefix for all commits in patch series:

4f8b516c3 (HEAD -> ligurio/gh-4842-qsync-testing) qsync: add test with 
change space sync mode in a loop
d9a3fff52 qsync: add test with random leaders promotion and demotion
8723e4cca qsync: test clear_synchro_queue() function
8889406fc qsync: test clear_synchro_queue() with unconfigured box

> The patch itself is good.