From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E78A521C7F for ; Mon, 14 Jan 2019 09:06:33 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BWRCkTMJujSy for ; Mon, 14 Jan 2019 09:06:33 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A573B21B65 for ; Mon, 14 Jan 2019 09:06:33 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH 5/6] sql: fix error message for improperly created index References: <834f24a401b7829d0bbad2e57985ab4040065046.1547035184.git.korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Mon, 14 Jan 2019 17:06:24 +0300 MIME-Version: 1.0 In-Reply-To: <834f24a401b7829d0bbad2e57985ab4040065046.1547035184.git.korablev@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Nikita Pettik Thanks for the patch! See 1 comment below. On 09/01/2019 15:13, Nikita Pettik wrote: > Table can be created without any indexes (for instance, from Lua-land). > On the other hand, bytecode generated for CREATE INDEX statement > attempts at finding entry in _index space with given space id. > In case it is not found error "wrong space id" is raised. On the other > hand, it is obvious that such message is appeared when table doesn't > have any created indexes yet. Hence, lets fix this message to indicate > that primary key should be created before any secondary indexes. > > Closes #3914 The test index1.test.lua fails. I guess, because you introduce ADD CONSTRAINT PRIMARY KEY only in the next commit. Lets move this part of the test into the latter.