From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 496615BFC15; Thu, 17 Aug 2023 10:44:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 496615BFC15 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692258276; bh=wfZo5rr+mdF4iNti3CThCcjXovOpYwW/M+qpuJeq4So=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=t1XfoRYT8F1DljoBxqMo6QT2t3ZEH6PWhiOxAoRUSXU3kGEv84jCjfbveZpa/5V6h uSk/WfoBl60yb53qCMDmZKNG9yli/WjLiM+s2tBQC6roWvqJA6bVdy9BuzNtCU+V1Z t35Q+NARx4hxeY4dAGRGiAmd8qjR4PwyLJWGUciA= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F0366581FDB for ; Thu, 17 Aug 2023 10:44:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F0366581FDB Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qWXgJ-0000pp-1i; Thu, 17 Aug 2023 10:44:35 +0300 Message-ID: Date: Thu, 17 Aug 2023 10:44:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Sergey Kaplun , Igor Munkin References: <3166f89d23b9986f3849f2873ee78285c034b894.1691592488.git.skaplun@tarantool.org> In-Reply-To: <3166f89d23b9986f3849f2873ee78285c034b894.1691592488.git.skaplun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D77D6FA938422CA5F653AC3988EEC6B12182A05F53808504049CAC04A83EF7C4243CD4F9D98435137E04ADFAF88576D52DE42BC4B349A7C7C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE721B3E54BB37EA0B4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FD60A286D0BA57028638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F989A09A43D4C7CA3D902E946655BF8A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC4AFB60FD1831C04CA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0D75EB778CE7D8A0C68655334FD4449CB1E561CDFBCA1751F35872C767BF85DA227C277FBC8AE2E8B81DF583BEE9BDE68EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5A0366F46DA11E07D10B0AC6476FF4BEB768D43959CACA240F87CCE6106E1FC07E67D4AC08A07B9B0457EE4B4996FC546CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF2591E8D1FF265D378DE5D1985E51C3343C2F5F39886156660DC34618F07E76CE698455FC0CD9C18224F7434E9608BF9F9891F7DE3F405A7E76DCEB211E8F33DFA74DFFEFA5DC0E7F02C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxpTBMDUABNHFg== X-DA7885C5: F296E47442BF6A3F61375CD59AD6C05BB8F9FA43EC770E1CD87520D7940A53C5262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B14D40E4C00B08E5E193D6A87320D2F94DD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 13/19] ARM: Fix GCC 7 -Wimplicit-fallthrough warnings. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! LGTM, but I have a question inline On 8/9/23 18:36, Sergey Kaplun wrote: > From: Mike Pall > > (cherry-picked from commit 9bd5a722bee2ee2c5b159a89937778b81be49915) > > This patch adds the `/* fallthrough */` comments elsewhere, where it was > missing for the ARM build, so the `-Wimplicit-fallthrough` [1] warning > is trigerred. > > Also, this commits sets the correspoinding flag in the > . > > [1]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough > > Sergey Kaplun: > * added the description for the commit > > Part of tarantool/tarantool#8825 > --- > cmake/SetTargetFlags.cmake | 6 ++++++ > src/lj_asm.c | 2 +- > src/lj_asm_arm.h | 4 ++-- > 3 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake > index 3b9e481d..d309989e 100644 > --- a/cmake/SetTargetFlags.cmake > +++ b/cmake/SetTargetFlags.cmake > @@ -8,6 +8,12 @@ > > include(CheckUnwindTables) > > +# Clang does not recognize comment markers. > +if (CMAKE_C_COMPILER_ID STREQUAL "GNU" > + AND CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL "7.1") GCC 7.1 because there was no 7.0 in release series 7 [1], right? 1. https://gcc.gnu.org/gcc-7/ > + AppendFlags(TARGET_C_FLAGS -Wimplicit-fallthrough) > +endif() > + > if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") > set(BUILDVM_MODE machasm) > else() # Linux and FreeBSD.