From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CDA527030F; Fri, 15 Jan 2021 15:41:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CDA527030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610714463; bh=sUNRY/qqW8eMrh0jFeqmxhe9nACJODL625xhJ8Ss504=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ERYe8XbUZfZ1u1w9Crk/YHNSpt+SAp6KlbeWRZmiGmF3yl/WAbmXoGt/m7j5xX330 JV+ynCUTzFWChezlTtb7fPOcIfMoxJoIKSTRiDmAYol3cl3KKkC/fVvRO9TIY0serY a7Es1yMOlwjpW4McRggx1PCd+U1zAXhJTAHMmI3Q= Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D15CE7030F for ; Fri, 15 Jan 2021 15:40:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D15CE7030F Received: by smtp16.mail.ru with esmtpa (envelope-from ) id 1l0OPT-0004JQ-4T; Fri, 15 Jan 2021 15:40:59 +0300 To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org References: Message-ID: Date: Fri, 15 Jan 2021 15:40:58 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CD520EA9A9E182CF906B1BCD0E5756442500894C459B0CD1B9D6542BDA57F50B2EC209E153600799946CD06EBA1D6A54F865B29713DD787B1E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FDE19FEC90BA7BD7C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE737BB76880A4CA9A4EA1F7E6F0F101C674E70A05D1297E1BBC6CDE5D1141D2B1C87FD77339525B2888E4F0F295AA8FD3DBB1AE98DD1D17A6B9FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BE2CCD8F0CAA010FB389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F79006373C42DF3E2CBB16C9D81D268191BDAD3DBD4B6F7A4D31EC0BEA7A3FFF5B025636D81D268191BDAD3D78DA827A17800CE7A73934366B756265EC76A7562686271EEC990983EF5C032935872C767BF85DA29E625A9149C048EE0A3850AC1BE2E7351D6A3D1828C120DE4AD6D5ED66289B524E70A05D1297E1BB35872C767BF85DA227C277FBC8AE2E8B29B35B35A61343BBEFF80C71ABB335746BA297DBC24807EA27F269C8F02392CDC58410348177836EABEDDA51113D120200306258E7E6ABB4E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A58785F9A87E95263DED107CC121694E2FE697076DA06DC25FD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758F9E841AEAEC4F2C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34315359784EE451039223804375B240F78158DAC0D2A11C6F1D9C2B96EF57A942D1D48B1CF13AEE881D7E09C32AA3244C441EC3BB84802CB84F96258385A17F94F165894D92D62706FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojT/h6YDL0UQ6NMSMRFqA8/A== X-Mailru-Sender: 583F1D7ACE8F49BDF28A51E06CB90EC1CB28DB18F2C7403D6A2DC5986296E365A6F5D00853804B9D823C4E0A9438D55D74690CA6451351EDEC462FDC9CAD1E11B969B486931C0B990F27244EEAA5B9A5AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/2] luacheck: fix warnings in test/box-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 15.01.2021 14:22, sergeyb@tarantool.org пишет: > From: Sergey Bronnikov > > Follows up #5457 > --- > test/box-tap/feedback_daemon.test.lua | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/test/box-tap/feedback_daemon.test.lua b/test/box-tap/feedback_daemon.test.lua > index 123033cda..8cfbf31d7 100755 > --- a/test/box-tap/feedback_daemon.test.lua > +++ b/test/box-tap/feedback_daemon.test.lua > @@ -124,8 +124,8 @@ local fh = fio.open("feedback.json") > test:ok(fh, "file is created") > local file_data = fh:read() > -- Ignore the report time. The data should be equal other than that. > -feedback_save = string.gsub(feedback_save, 'time:(%d+)', 'time:0') > -file_data = string.gsub(feedback_save, 'time:(%d+)', 'time:0') > +feedback_save = string.gsub(feedback_save, '"time":(%d+)', 'time:0') > +file_data = string.gsub(file_data, '"time":(%d+)', 'time:0') Thanks for finding this typo! Please also replace `time:0` with `"time":0` Other than that LGTM. > test:is(file_data, feedback_save, "data is equal") > fh:close() > fio.unlink("feedback.json") > @@ -247,7 +247,7 @@ box.space.features_memtx_empty:drop() > box.space.features_memtx:drop() > box.space.features_sync:drop() > > -function check_stats(stat) > +local function check_stats(stat) > local sub = test:test('feedback operation stats') > sub:plan(18) > local box_stat = box.stat() -- Serge Petrenko