From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4A70626E70
	for <tarantool-patches@freelists.org>; Tue, 17 Jul 2018 17:48:28 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id tMeGrLmMDnoi for <tarantool-patches@freelists.org>;
	Tue, 17 Jul 2018 17:48:28 -0400 (EDT)
Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 06C8726E64
	for <tarantool-patches@freelists.org>; Tue, 17 Jul 2018 17:48:27 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v1 1/1] lua: fix strange behaviour
 of tonumber64
References: <c0b9b7681a21a06339a3e3b5e183597951a810d6.1531480776.git.kshcherbatov@tarantool.org>
 <6b638fd3-58bc-2ed7-c32c-3f0a440d1f2b@tarantool.org>
 <20180716124949.3uhj5zrkivphdnaw@tkn_work_nb>
 <ac001997-5bfb-443d-5f21-ac345a29bd7d@tarantool.org>
 <20180716134210.zp3tckp3gcgchm4q@tkn_work_nb>
 <56a17552-ddcf-08cd-3ce1-78018f9dc748@tarantool.org>
 <20180716140907.62lazzvz4vx2e7fz@tkn_work_nb>
 <58f21346-5ae1-97fe-2231-0d86f3c9717f@tarantool.org>
 <8b7eb4a3-3aec-a63c-034e-fd0ace55d0d9@tarantool.org>
 <20180717112746.mh2cqq22acw4mtsu@tkn_work_nb>
 <8bda0436-9681-5662-9f51-927cbf26fbae@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <c14a8b95-2437-f0e6-0c2b-9fc6a4fe4090@tarantool.org>
Date: Wed, 18 Jul 2018 00:48:25 +0300
MIME-Version: 1.0
In-Reply-To: <8bda0436-9681-5662-9f51-927cbf26fbae@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>, tarantool-patches@freelists.org, Alexander Turenko <alexander.turenko@tarantool.org>

Thanks for the fixes! I have fixed the commit
message on the branch. Now the patch LGTM.

On 17/07/2018 15:03, Kirill Shcherbatov wrote:
>>>> +-- gh-3466: Strange behaviour of tonumber64 function
>>>> +--
>>>> +tostring(tonumber64('18446744073709551615')) == '18446744073709551615ULL'
>>>> +tonumber64('18446744073709551616') == nil
>>> 2. Where is a test for another corner case? I mean INT64_MAX.
> Actually, the max value is not INT64_MAX; but UINT64_MAX that is tested above.
> But I don't mind to add INT64_MAX test.
> +tostring(tonumber64('9223372036854775807')) == '9223372036854775807ULL'
> 
>> I also propose to test zero.
> +tostring(tonumber64('0')) == '0'
> 
>> 1. Please, add a comment about the things we have discussed as Alexander asked
>> in the previous message.
> +                               /*
> +                                * To test overflow, consider
> +                                *  result > -INT64_MIN;
> +                                *  result - 1 > -INT64_MIN - 1;
> +                                * Assumption:
> +                                *  INT64_MAX == -(INT64_MIN + 1);
> +                                * Finally,
> +                                *  result - 1 > INT64_MAX;
> +                                */
>