From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C2582469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  9 Mar 2020 01:57:21 +0300 (MSK)
References: <20200117170801.34975-1-maria.khaydich@tarantool.org>
 <1583258709.640377144@f153.i.mail.ru>
 <4d2bb331-d104-3e45-c84c-580cdfdbf1a7@tarantool.org>
 <1583497159.97035585@f104.i.mail.ru>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <c0d5d57e-4000-0968-81d4-c4486047ded7@tarantool.org>
Date: Sun, 8 Mar 2020 23:57:20 +0100
MIME-Version: 1.0
In-Reply-To: <1583497159.97035585@f104.i.mail.ru>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] box: netbox.self and connect should
 work interchangeably
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Maria Khaydich <maria.khaydich@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Thanks for working on this, LGTM.

Here is @ChangeLog for Kirill:
- netbox.self:call/eval() now returns all the same types, as
  netbox_connection:call/eval. Previously it could return
  tuple or box.error cdata (gh-4513).

Since we got 2 LGTMs, I committed the patch to master, 2.3, 2.2,
1.10. The changelog is added to release notes.