From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1B998289E2 for ; Mon, 13 Aug 2018 16:24:36 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GzX6LOQOmz8x for ; Mon, 13 Aug 2018 16:24:36 -0400 (EDT) Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D1CC028910 for ; Mon, 13 Aug 2018 16:24:35 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 01/10] sql: remove suport of ALTER TABLE ADD COLUMN References: <79f1fcdbe341c14cf973398941c98946f04c508f.1534001739.git.korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Mon, 13 Aug 2018 23:24:33 +0300 MIME-Version: 1.0 In-Reply-To: <79f1fcdbe341c14cf973398941c98946f04c508f.1534001739.git.korablev@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Nikita Pettik Hi! Thanks for the patch! I have pushed my review fixes in a separate commit. On 12/08/2018 17:12, Nikita Pettik wrote: > We disabled ALTER TABLE ADD COLUMN long ago (i.e. banned in parser > ability to process this statement), but internal functions for handling > this routine have remained. This patch removes them as well. > > Part of #3561 > --- > src/box/sql/alter.c | 185 ------------------------------------------------ > src/box/sql/build.c | 16 +---- > src/box/sql/parse.y | 12 ++-- > src/box/sql/sqliteInt.h | 7 +- > 4 files changed, 7 insertions(+), 213 deletions(-) >