From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E833CB85E1D; Tue, 26 Mar 2024 17:01:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E833CB85E1D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1711461701; bh=vBkHk0TljhzmqhLGlgZvHhD7GAqttUY3DMnOFBrywAo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GMx3Dg+ZuW7dGErQWHxG9ZkUJufCo5/+f2TjHa2VI/HLkvxEGrHvVbzQwagyk4imN eBjDjo+sAcKke5bYiuaWY4ptQoxvDciGuN1+ehEuaBPBGCpJIQPpF6VPFbjZlITXYz E4m7Tf9Ql5k0A0rFTHYJcAKWGyRH0viA6uMCiGtY= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [95.163.41.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 14E9FB85E1D for ; Tue, 26 Mar 2024 17:01:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 14E9FB85E1D Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1rp7Mx-0000000HHLu-1s7R; Tue, 26 Mar 2024 17:01:39 +0300 Message-ID: Date: Tue, 26 Mar 2024 17:01:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maxim Kokryashkin References: <1fe5f0ebbd285bd58849be28548bcc8c8c68c2a1.1710416150.git.sergeyb@tarantool.org> <5fprjxcjy4f4ugliudwqmc5pu4xbv53vdir34hl6gu2vtgjtfe@fqtnkjrf4z4l> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD905284D235AF2CB533F0AB082C978B4EBC8EE48D699DE6FC1182A05F5380850400A5236BFD111104689CEA9C911D099950E841655154A5B811746037C3D0EF9587EDAE2B993BF3920 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BCC85671EC7A750CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637188F5654332B449D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81540CD2CC37A0E14B6516DB7DDBAB185346AEDE58E9A9758CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CBFD98ABA943BD70B040F9FF01DFDA4A84AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C394C7EA7F95207A85BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFCF36E64A7E3F8E581DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3F8A0C55DE5E8D0B235872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A53892850E8ED19E335002B1117B3ED6963420C8026E837E58BFF4097FFC9E796F823CB91A9FED034534781492E4B8EEAD47A3109F1ACFD409BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFAFC0AFF112F33B9AA26D1724AEBA1B4C668518FEA4542B563EEEA5662486B41417C141E43CE0FC0BF212F37558E72466DDD1786FCE95857FF8565B7B566559B216D376EFAE899ED2C226CC413062362A913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhu0AwaaKnHqoV8TtHRhBlA== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59CE0977C22781C40A89CEA9C911D099950E841655154A5B81B7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] OSX/iOS/ARM64: Fix bytecode embedding in Mach-O object file. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, changes force-pushed. On 3/19/24 19:15, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the fixes! > See my answer for the last unresolved comment below. > On Tue, Mar 19, 2024 at 11:22:20AM +0300, Sergey Bronnikov wrote: >> Max, >> >> thanks for review. See my comments below. >> >> Changes force-pushed. >> >> On 3/18/24 16:44, Maxim Kokryashkin wrote: > >>>> diff --git a/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua b/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua >>>> index 0519e134..0a11f163 100644 >>>> --- a/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua >>>> +++ b/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua >>>> @@ -7,7 +7,7 @@ local test = tap.test('lj-865-fix_generation_of_mach-o_object_files'):skipcond({ >>>> ['Test uses exotic type of loaders (see #9671)'] = _TARANTOOL, >>>> }) >>>> >>>> -test:plan(4) >>>> +test:plan(8) >>>> >>>> -- Test creates an object file in Mach-O format with LuaJIT bytecode >>>> -- and checks validness of the object file fields. > Typo: s/validness/the validity/ Fixed. >>>> @@ -267,5 +267,7 @@ end >>>> >>>> -- ARM >>>> build_and_check_mach_o(false) >>>> +-- ARM64 >>>> +build_and_check_mach_o(true) >>> These `true/false` should be explained as platform toggle. >>> An even better solution would be to pass the platform name >>> explicitly. >> Why comment above is not sufficient? > Comment is sufficient, sure, but why should you opt for a comment, when > you can write self-explanatory code instead? Fixed. 'arm' or 'arm64' are passed to a test func. I believe this is clear enough for reader. >>>> test:done(true) >>>> -- >>>> 2.34.1 >>>>