From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5E2C424F53 for ; Thu, 12 Jul 2018 04:54:53 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BJMPCsAXhcQp for ; Thu, 12 Jul 2018 04:54:53 -0400 (EDT) Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1B49924DA5 for ; Thu, 12 Jul 2018 04:54:53 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: fix assertion on invalid PK column name References: <1741e4e16438af3e3cb88ecd84a64faf711ad661.1531376946.git.kshcherbatov@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Thu, 12 Jul 2018 11:54:49 +0300 MIME-Version: 1.0 In-Reply-To: <1741e4e16438af3e3cb88ecd84a64faf711ad661.1531376946.git.kshcherbatov@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org Hello. Thanks for the patch! I know, that removal of assertion always 'fixes' it, but please, either fix it without removal (and for me it is not obvious why it should be removed), or explain, why it is invalid. On 12/07/2018 09:30, Kirill Shcherbatov wrote: > Close #3522. > --- > https://github.com/tarantool/tarantool/compare/kshch/gh-3522-invalid-primary-key-column-name > https://github.com/tarantool/tarantool/issues/3522 > > src/box/sql/build.c | 1 - > test/sql/gh-2929-primary-key.result | 7 +++++++ > test/sql/gh-2929-primary-key.test.lua | 5 +++++ > 3 files changed, 12 insertions(+), 1 deletion(-) >