From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8AA842A2AF
	for <tarantool-patches@freelists.org>; Mon,  1 Apr 2019 16:39:20 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id JRLpUTcfMdbC for <tarantool-patches@freelists.org>;
	Mon,  1 Apr 2019 16:39:20 -0400 (EDT)
Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 44DD529DAA
	for <tarantool-patches@freelists.org>; Mon,  1 Apr 2019 16:39:20 -0400 (EDT)
From: Stanislav Zudin <szudin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 03/13] sql: removes unused
 function.
References: <cover.1552663061.git.szudin@tarantool.org>
 <cover.1552663061.git.szudin@tarantool.org>
 <0dca725d7fa92fc2fe4d9b365eb0506035414662.1552663061.git.szudin@tarantool.org>
 <AF1C0992-8933-4AD0-8044-BCE373085C88@tarantool.org>
Message-ID: <c040fea2-dcf4-6d4d-7c11-8420f6ccb597@tarantool.org>
Date: Mon, 1 Apr 2019 23:39:18 +0300
MIME-Version: 1.0
In-Reply-To: <AF1C0992-8933-4AD0-8044-BCE373085C88@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, "n.pettik" <korablev@tarantool.org>



On 25.03.2019 18:11, n.pettik wrote:
> 
>> diff --git a/src/box/sql/main.c b/src/box/sql/main.c
>> index 9fe2e2c9d..a3c59b126 100644
>> --- a/src/box/sql/main.c
>> +++ b/src/box/sql/main.c
>> @@ -1910,22 +1910,6 @@ sql_uri_boolean(const char *zFilename, const char *zParam, int bDflt)
>> 	return z ? sqlGetBoolean(z, bDflt) : bDflt;
>> }
>>
>> -/*
>> - * Return a 64-bit integer value for a query parameter.
>> - */
>> -sql_int64
>> -sql_uri_int64(const char *zFilename,	/* Filename as passed to xOpen */
>> -		  const char *zParam,	/* URI parameter sought */
>> -		  sql_int64 bDflt)	/* return if parameter is missing */
>> -{
>> -	const char *z = sql_uri_parameter(zFilename, zParam);
>> -	int64_t v;
>> -	if (z != NULL && sql_dec_or_hex_to_i64(z, false, &v) == 0)
>> -		bDflt = v;
>> -	return bDflt;
>> -}
>> -
> 
> What about other functions from this family?
> They seem to be unused as well.
> 
> 
Removed unused functions sql_uri_boolean(
and the code underneath SQL_ENABLE_8_3_NAMES.