From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4DDC3226F7 for ; Mon, 7 May 2018 19:12:50 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2o2H4OHwa2WP for ; Mon, 7 May 2018 19:12:50 -0400 (EDT) Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 97A49226DC for ; Mon, 7 May 2018 19:12:49 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE References: <399639c2-dcd6-da4b-8402-f0ec10f3ea74@tarantool.org> <1154681525719011@web34j.yandex.ru> From: Vladislav Shpilevoy Message-ID: Date: Tue, 8 May 2018 02:12:44 +0300 MIME-Version: 1.0 In-Reply-To: <1154681525719011@web34j.yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, roman.habibov1@yandex.ru On 07/05/2018 21:50, roman.habibov1@yandex.ru wrote: > diff --git a/commits/1 b/commits/1 > index 27ef2f6..dee20d6 100644 > > @@ -5,7 +5,7 @@ Date: Sat, 5 May 2018 01:45:06 +0300 > Subject: [PATCH v1 1/1] sql: tests for CREATE TEMP TABLE and CREATE TEMPORARY > TABLE > > 07.05.2018, 16:08, "Vladislav Shpilevoy" : >> 1. Please, in the commit title write a Tarantool submodule prefix. For example, >> your patch is about SQL, so you would write 'sql: ' prefix. > > diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua > index 4882b18..21213bc 100755 > --- a/test/sql-tap/table.test.lua > +++ b/test/sql-tap/table.test.lua > @@ -611,6 +611,9 @@ test:do_execsql2_test( > -- SELECT * FROM [t4"abc]; > -- } > -- } {cnt 1 max(b+c) 5} > + > +-- gh-2166 functions with TEMP and TEMPORARY are removed, tests needed to show that Please, do not write 'tests needed to show that' - all tests are needed to show something, it is obvious. At second, align the comments by 66 maximal symbols in line, and put a dot at the end of sentence. > + > test:do_catchsql_test( > "temp", > [[ > > 07.05.2018, 16:08, "Vladislav Shpilevoy" : >> 2. Before the test cases write in comments what do you test here, and >> :write a link to the issue in the format 'gh-NNNN: description'. >