From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F2D8DF5422C; Fri, 11 Oct 2024 21:52:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F2D8DF5422C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1728672723; bh=8vCz7QKcz8XNG+PkWvVmGPKHmWhVMKgaIoesVrwbN0w=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=P9ryQlcP5/DdXHM3XRdttpFMeN8dWbMBbkqJyDJzm5Wao2JqSVHILrc463QfoScxD NBuuUIwdnKxIYTTfu1JroTawGA+JJFGBVcDXReFa6e2knePmwMulAETX2t+r5c5g4k NA41pnO6BHMOUiWTB42aHzYR9mWWtXSL58fYpAYM= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [95.163.41.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 37140F5421C for ; Fri, 11 Oct 2024 21:52:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 37140F5421C Received: by exim-smtp-57f79c7799-f4kl8 with esmtpa (envelope-from ) id 1szKk5-00000000AVn-0RwJ; Fri, 11 Oct 2024 21:52:01 +0300 Date: Fri, 11 Oct 2024 21:51:59 +0300 To: Sergey Kaplun Message-ID: References: <20240928103359.16057-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240928103359.16057-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9B01871A0ED523BBFDF1960DC08D49231687A55EF79E1518C182A05F538085040562B6B6FB46C7D8F3DE06ABAFEAF6705CBD7406FA43DC33C0DB01A25F27622D332558796127ABEF6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7811C3E343B302E2EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378997215BCAA11D778638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D859B9A800CCF6B80AC95FBBAC7F4C78BA2B583E3AD0CFCDF7CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637EF56C58EEA55AA68D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE70DB7A41A747CC8E1EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3CD42BCEBB57B85E635872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A54F522FD1B638E4AE5002B1117B3ED69629DD24CFB678961972305013E4AE841E823CB91A9FED034534781492E4B8EEADD0953842B444AAC3BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D349FF8F8245A2FAA7BB2E507D9BD2CFBDF46529AB7C07A0F0A1038F387478B82AB09675D0A95ECAA501D7E09C32AA3244C638D76763F46C79577DD89D51EBB7742CE80FBBF21B54FF5EA455F16B58544A2557BDE0DD54B3590965026E5D17F6739C77C69D99B9914278E50E1F0597A6FD5CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMU25eydo6+krg+g5ORhEWA== X-Mailru-Sender: E3D314023ABB569D87C73134501BE95A6216C2B97D5ECBEEB3484BDBBEAF68BA25329392EC1C4FD828C44B9C631FF20DE747D2BC1AD30F01FB559BB5D741EB9612EB40C6FA10D71EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix misclib-getmetrics-lapi.test.lua X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for a single nit regarding the commit message: On Sat, Sep 28, 2024 at 01:33:59PM GMT, Sergey Kaplun wrote: > When run under Tarantool, the test may fail if Tarantool already has > performed some finalize steps. This patch fixes it by making the test > more general. > --- IMO, it would be more readable to paraphrase like: | When executed in Tarantool, the test might fail if Tarantool has | already completed certain finalization steps. This patch | addresses the issue by making the test more adaptable.