From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A479046970F for ; Sat, 23 Nov 2019 16:39:02 +0300 (MSK) From: Vladislav Shpilevoy References: Message-ID: Date: Sat, 23 Nov 2019 14:45:42 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 0/6] Synchronous replication preparation List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Georgy Kirichenko , tarantool-patches@dev.tarantool.org Hi! You have 9 commits on top of this branch. What should I review? Please, drop the commits not related to this patchset from the branch. Look at CI, it is broken: https://travis-ci.org/tarantool/tarantool/builds/614719290?utm_source=github_status&utm_medium=notification box-py/iproto.test.py does not pass. > Georgy Kirichenko (6): > recovery: do not throw an error > coio: do not htrow an exception > xstream: get rid of an exception > vinyl: do not insert vy_tx twice into writers list > box: improve recovery journal > recovery: follow transaction boundaries while recovery or join > > src/box/applier.cc | 140 ++++++++-------- > src/box/box.cc | 119 ++++++++++---- > src/box/recovery.cc | 87 ++++++---- > src/box/recovery.h | 14 +- > src/box/relay.cc | 47 +++--- > src/box/vy_tx.c | 2 +- > src/box/xrow_io.cc | 59 +++---- > src/box/xrow_io.h | 11 +- > src/box/xstream.cc | 7 +- > src/box/xstream.h | 2 +- > src/lib/core/coio.cc | 212 +++++++++++++------------ > src/lib/core/coio.h | 13 +- > src/lib/core/coio_buf.h | 8 + > test/xlog-py/big_lsn.result | 4 + > test/xlog-py/big_lsn.test.py | 13 +- > test/xlog-py/dup_key.result | 8 + > test/xlog-py/dup_key.test.py | 7 + > test/xlog/panic_on_broken_lsn.result | 9 +- > test/xlog/panic_on_broken_lsn.test.lua | 7 +- > 19 files changed, 449 insertions(+), 320 deletions(-) >