From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B4C6C4C6301; Fri, 14 Jul 2023 15:36:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B4C6C4C6301 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689338203; bh=z7YVVkRbOKt3xp223pabv+5OJ9nzW8KqqtRCsr5hSCk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NA5BJKNx4kBw3EvxkezDs7bg/sk19K3Nskmo/Uvtn1OSY8Q/UynRVj6pquUDvX8sm SJSzjhuiSXSyJ2D0nlh3rRs+ASkA4mqec7PiQYGUYRLeO4qrec/JtPBmCW2nEQkD8u 8a77Xf/tU+VCVkysJr3wqKs0PViMMnEYb2U4uTuA= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [95.163.41.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D94914C6301 for ; Fri, 14 Jul 2023 15:36:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D94914C6301 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1qKI2L-002OAF-4x; Fri, 14 Jul 2023 15:36:41 +0300 Message-ID: Date: Fri, 14 Jul 2023 15:36:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Sergey Kaplun , Sergey Bronnikov References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9A075ED63965291975FF12524F3FDD82BF1CE581C66542C39182A05F538085040F06926F23C004090E66A33F77F05C5B57DB20B414F83DCF983E05DF3B35501BB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7590E57235B5C00BDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637826327602763C04B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D866F0DA9F25D239BC01467C9213BA542F117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B1F3D1E7C87716A07A471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FC93AA53B0B255C7C23AA81AA40904B5D9CF19DD082D7633A0C84D3B47A649675F3AA81AA40904B5D98AA50765F79006375F9A1B9E53A3C84ED81D268191BDAD3D3666184CF4C3C14F3FC91FA280E0CE3D1A620F70A64A45A98AA50765F7900637F9425D8FA97DB4396D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5FE3573D7B6AEA801EBFD4045A2850DB8E385E33AE935A02AF87CCE6106E1FC07E67D4AC08A07B9B0E753FA5741D1AD02CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D343F22CE0A71FDB37E6B007739144C47ABDDDBA099601BD8A073ACD791FAFB637D9AF022E6CD1BD2FE1D7E09C32AA3244C85CC4F1A4D21AF3165C2B195B0460330F26BFA4C8A6946B8BAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrC/lX9ZwUYo2Kb9/xdQCwA== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A7694E3E0CA7FD7BB224E66A33F77F05C5B5BA0848438379BFCEEBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] test: fix typos X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for review! Updated branch force-pushed. On 7/14/23 14:53, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except some comments below: > > 1) I suppose it should be named `refactoring: fix typos`, since we also > changed debugger scripts and tools files. Feel free to split this commit > into three for each subsystem, but I see no need in this. Agreed offline to change to "codehealth". > On 11.07.23, Sergey Bronnikov wrote: >> From: Sergey Bronnikov >> >> Fix typos found with codespell in a files with our own source code. > Typo: s/a files/files/ Fixed! >> diff --git a/tools/memprof/process.lua b/tools/memprof/process.lua >> index 0bcb965b..9dc202ae 100644 >> --- a/tools/memprof/process.lua >> +++ b/tools/memprof/process.lua >> @@ -39,8 +39,8 @@ function M.form_heap_delta(events, symbols) >> for _, heap_chunk in pairs(event.primary) do >> local ev_line = symtab.demangle(symbols, heap_chunk.loc) >> >> - if (heap_chunk.alloced > 0) then >> - dheap[ev_line].dbytes = dheap[ev_line].dbytes + heap_chunk.alloced >> + if (heap_chunk.allocated > 0) then >> + dheap[ev_line].dbytes = dheap[ev_line].dbytes + heap_chunk.allocated >> dheap[ev_line].nalloc = dheap[ev_line].nalloc + heap_chunk.count >> end > 2) Can we avoid such changes in the not-string/non-comment chunks? I suppose no in checkpatch. These typos were found by manual codespell run.