From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7BBC825B8B for ; Wed, 30 May 2018 04:32:11 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZZ-xv8xcUnFB for ; Wed, 30 May 2018 04:32:11 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B983425B8A for ; Wed, 30 May 2018 04:32:10 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v7 5/7] sql: change sqlite3AddCheckConstraint signature References: <5B54C4CB-55F6-49AB-BECB-1CF679F535F7@tarantool.org> From: Kirill Shcherbatov Message-ID: Date: Wed, 30 May 2018 11:32:06 +0300 MIME-Version: 1.0 In-Reply-To: <5B54C4CB-55F6-49AB-BECB-1CF679F535F7@tarantool.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: "n.pettik@corp.mail.ru" , "v.shpilevoy@tarantool.org" > Lets use ‘struct’ prefix, as it should be according to codestyle. > The same. diff --git a/src/box/sql/build.c b/src/box/sql/build.c index 50e4985..db8e0ce 100644 --- a/src/box/sql/build.c +++ b/src/box/sql/build.c @@ -1020,10 +1020,10 @@ sqlite3AddPrimaryKey(Parse * pParse, /* Parsing context */ } void -sql_add_check_constraint(Parse *parser, ExprSpan *span) +sql_add_check_constraint(struct Parse *parser, struct ExprSpan *span) { struct Expr *expr = span->pExpr; - Table *table = parser->pNewTable; + struct Table *table = parser->pNewTable; if (table != NULL) { table->pCheck = sqlite3ExprListAppend(parser, table->pCheck, expr); >> + * Add a new CHECK constraint to the table currently under construction. > > Out of 66 chars. diff --git a/src/box/sql/sqliteInt.h b/src/box/sql/sqliteInt.h index 10732aa..87ebbfb 100644 --- a/src/box/sql/sqliteInt.h +++ b/src/box/sql/sqliteInt.h @@ -3506,7 +3506,8 @@ void sqlite3AddNotNull(Parse *, int); void sqlite3AddPrimaryKey(Parse *, ExprList *, int, int, enum sort_order); /** - * Add a new CHECK constraint to the table currently under construction. + * Add a new CHECK constraint to the table currently under + * construction. * @param parser Parsing context. * @param span Expression span object. */