From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 59D49445320
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 16 Jul 2020 03:05:18 +0300 (MSK)
References: <1594821336-14468-1-git-send-email-alyapunov@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <bec910ea-c16f-546a-5368-20bf008b287f@tarantool.org>
Date: Thu, 16 Jul 2020 02:05:16 +0200
MIME-Version: 1.0
In-Reply-To: <1594821336-14468-1-git-send-email-alyapunov@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 00/13] Transaction engine for
 memtx engine
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Aleksandr Lyapunov <alyapunov@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for the patchset!

On 15.07.2020 15:55, Aleksandr Lyapunov wrote:
> Changes in v3:
>   - Fixes after code review
>   - Lots of comments added
>   - Code cleanup
>   - A couple of bugs fixed
> 
> Aleksandr Lyapunov (13):
>   Update license file (2020)
>   Check data_offset overflow in struct tuple
>   vinyl: rename tx_manager -> vy_tx_manager
>   txm: introduce dirty tuples
>   txm: save txn in txn_stmt
>   txm: add TX status
>   txm: save does_require_old_tuple flag in txn_stmt
>   txm: introduce tx manager
>   tmx: introduce prepare sequence number
>   tmx: introduce conflict tracker

In some commit titles you use tmx instead of txm. Is it
intentional? If yes, then what tmx means?

>   txm: introduce txm_story
>   txm: clarify all fetched tuples
>   tmx: use new tx manager in memtx