From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0600016599F0; Tue, 23 Dec 2025 13:39:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0600016599F0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1766486368; bh=l4GDLSDCMeWPT2yyORxagAT0RIhnMfBOiEqVloVIaXo=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=k9BwWd5ZxgdkjZWEBo/iW2xvdXaG6nvuCBcL+R99bgcu9Tsa2sQWLbV2445A675co eST+FzzhTFTPkAwhOkjJ84GO8FTVWDEwCS0qXoOV/xUlYfhd0LtEDr0cFSeqjF85Mn ChovnFS5RQdU9j9bLqBPs7ZF6So5OArVYoUjPwbk= Received: from send194.i.mail.ru (send194.i.mail.ru [95.163.59.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B51CA16599E1 for ; Tue, 23 Dec 2025 13:38:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B51CA16599E1 Received: by exim-smtp-7b4fb89df9-f7qdb with esmtpa (envelope-from ) id 1vXzmG-0000000046l-2rDg; Tue, 23 Dec 2025 13:38:05 +0300 Content-Type: multipart/alternative; boundary="------------HrRBXf0jAg4mMjYq3wv5reic" Message-ID: Date: Tue, 23 Dec 2025 13:38:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9169BA2A4A1D10D0062704CAB6E7D333A6DF0C3F071CADCBE182A05F538085040E87A9B3697A1E7B33DE06ABAFEAF67056E2AC7E668CD4FB46DBB412B9F8581CAE92FE53D5AEB5747 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A34C649281B21B01EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566EF210049E62C3CC5E7D312825B047F22D146867C1E5D46D78DBEF6AC3FB534C0389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22493D8A1CC48EE1840876E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8BB4B47AF75261DAE93AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE493B89ED3C7A6281781D028CC0B556B22BCC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5C2715034C487E6005002B1117B3ED696B0B862FDB9749ED1466072E6821086B3823CB91A9FED034534781492E4B8EEADCAFEFF123806BC82BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659C15E6D27E4530EE2AF1BF80AF81FC7FC60E5AD676BD58F87C49C002A1B1E0BC4534CB314EADAEAA0B8341EE9D5BE9A0ABCAB6C187A46334E05CB097BA505BE420CFE08C232CEA62E8CD93680B12512CF4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdtTL5f5BIXbCQcgsJYMl24= X-Mailru-Sender: 811C44EDE0507D1FFB106D83BFFB684FBE88B6E9B9051C6691CF6C6A8F7D6EF6E8A9DEBAADF0D1E076A57DEB513830E0645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 14/41] perf: adjust mandelbrot in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------HrRBXf0jAg4mMjYq3wv5reic Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! See my comments. Sergey On 10/24/25 13:50, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > > The output is redirected to /dev/null. The check is skipped since it is > very inconvenient to check the binary output, especially since it may be > configured by the parameter. > --- > perf/LuaJIT-benches/mandelbrot.lua | 64 +++++++++++++++++++++--------- > 1 file changed, 45 insertions(+), 19 deletions(-) > > diff --git a/perf/LuaJIT-benches/mandelbrot.lua b/perf/LuaJIT-benches/mandelbrot.lua > index 0ef595a2..51e0dd4f 100644 > --- a/perf/LuaJIT-benches/mandelbrot.lua > +++ b/perf/LuaJIT-benches/mandelbrot.lua > @@ -1,23 +1,49 @@ > +local bench = require("bench").new(arg) > > -local write, char, unpack = io.write, string.char, unpack > -local N = tonumber(arg and arg[1]) or 100 > -local M, ba, bb, buf = 2/N, 2^(N%8+1)-1, 2^(8-N%8), {} > -write("P4\n", N, " ", N, "\n") > -for y=0,N-1 do > - local Ci, b, p = y*M-1, 1, 0 > - for x=0,N-1 do > - local Cr = x*M-1.5 > - local Zr, Zi, Zrq, Ziq = Cr, Ci, Cr*Cr, Ci*Ci > - b = b + b > - for i=1,49 do > - Zi = Zr*Zi*2 + Ci > - Zr = Zrq-Ziq + Cr > - Ziq = Zi*Zi > - Zrq = Zr*Zr > - if Zrq+Ziq > 4.0 then b = b + 1; break; end > +local N = tonumber(arg and arg[1]) or 5000 > + > +local function payload() > + -- These functions must not be an upvalue but the stack slot. > + local N = N > + local write, char, unpack = io.write, string.char, unpack > + local M, ba, bb, buf = 2/N, 2^(N%8+1)-1, 2^(8-N%8), {} please add more whitespaces. Here and below. > + write("P4\n", N, " ", N, "\n") > + for y=0,N-1 do > + local Ci, b, p = y*M-1, 1, 0 > + for x=0,N-1 do > + local Cr = x*M-1.5 > + local Zr, Zi, Zrq, Ziq = Cr, Ci, Cr*Cr, Ci*Ci > + b = b + b > + for i=1,49 do > + Zi = Zr*Zi*2 + Ci > + Zr = Zrq-Ziq + Cr > + Ziq = Zi*Zi > + Zrq = Zr*Zr > + if Zrq+Ziq > 4.0 then b = b + 1; break; end > + end > + if b >= 256 then p = p + 1; buf[p] = 511 - b; b = 1; end > end > - if b >= 256 then p = p + 1; buf[p] = 511 - b; b = 1; end > + if b ~= 1 then p = p + 1; buf[p] = (ba-b)*bb; end > + write(char(unpack(buf, 1, p))) > end > - if b ~= 1 then p = p + 1; buf[p] = (ba-b)*bb; end > - write(char(unpack(buf, 1, p))) > end > + > +local stdout = io.output() > + > +bench:add({ > + name = "mandelbrot", > + items = N, > + -- XXX: This is inconvenient to have the binary file in the > + -- repository for the comparison. If the check is needed run, > + -- the payload manually. > + skip_check = true, > + setup = function() > + io.output("/dev/null") > + end, > + teardown = function() > + io.output(stdout) > + end, > + payload = payload, > +}) > + > +bench:run_and_report() --------------HrRBXf0jAg4mMjYq3wv5reic Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! See my comments.

Sergey

On 10/24/25 13:50, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.

The output is redirected to /dev/null. The check is skipped since it is
very inconvenient to check the binary output, especially since it may be
configured by the parameter.
---
 perf/LuaJIT-benches/mandelbrot.lua | 64 +++++++++++++++++++++---------
 1 file changed, 45 insertions(+), 19 deletions(-)

diff --git a/perf/LuaJIT-benches/mandelbrot.lua b/perf/LuaJIT-benches/mandelbrot.lua
index 0ef595a2..51e0dd4f 100644
--- a/perf/LuaJIT-benches/mandelbrot.lua
+++ b/perf/LuaJIT-benches/mandelbrot.lua
@@ -1,23 +1,49 @@
+local bench = require("bench").new(arg)
 
-local write, char, unpack = io.write, string.char, unpack
-local N = tonumber(arg and arg[1]) or 100
-local M, ba, bb, buf = 2/N, 2^(N%8+1)-1, 2^(8-N%8), {}
-write("P4\n", N, " ", N, "\n")
-for y=0,N-1 do
-  local Ci, b, p = y*M-1, 1, 0
-  for x=0,N-1 do
-    local Cr = x*M-1.5
-    local Zr, Zi, Zrq, Ziq = Cr, Ci, Cr*Cr, Ci*Ci
-    b = b + b
-    for i=1,49 do
-      Zi = Zr*Zi*2 + Ci
-      Zr = Zrq-Ziq + Cr
-      Ziq = Zi*Zi
-      Zrq = Zr*Zr
-      if Zrq+Ziq > 4.0 then b = b + 1; break; end
+local N = tonumber(arg and arg[1]) or 5000
+
+local function payload()
+  -- These functions must not be an upvalue but the stack slot.
+  local N = N
+  local write, char, unpack = io.write, string.char, unpack
+  local M, ba, bb, buf = 2/N, 2^(N%8+1)-1, 2^(8-N%8), {}
please add more whitespaces. Here and below. 
+  write("P4\n", N, " ", N, "\n")
+  for y=0,N-1 do
+    local Ci, b, p = y*M-1, 1, 0
+    for x=0,N-1 do
+      local Cr = x*M-1.5
+      local Zr, Zi, Zrq, Ziq = Cr, Ci, Cr*Cr, Ci*Ci
+      b = b + b
+      for i=1,49 do
+        Zi = Zr*Zi*2 + Ci
+        Zr = Zrq-Ziq + Cr
+        Ziq = Zi*Zi
+        Zrq = Zr*Zr
+        if Zrq+Ziq > 4.0 then b = b + 1; break; end
+      end
+      if b >= 256 then p = p + 1; buf[p] = 511 - b; b = 1; end
     end
-    if b >= 256 then p = p + 1; buf[p] = 511 - b; b = 1; end
+    if b ~= 1 then p = p + 1; buf[p] = (ba-b)*bb; end
+    write(char(unpack(buf, 1, p)))
   end
-  if b ~= 1 then p = p + 1; buf[p] = (ba-b)*bb; end
-  write(char(unpack(buf, 1, p)))
 end
+
+local stdout = io.output()
+
+bench:add({
+  name = "mandelbrot",
+  items = N,
+  -- XXX: This is inconvenient to have the binary file in the
+  -- repository for the comparison. If the check is needed run,
+  -- the payload manually.
+  skip_check = true,
+  setup = function()
+    io.output("/dev/null")
+  end,
+  teardown = function()
+    io.output(stdout)
+  end,
+  payload = payload,
+})
+
+bench:run_and_report()
--------------HrRBXf0jAg4mMjYq3wv5reic--