From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CA659469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  9 Jun 2020 02:55:56 +0300 (MSK)
References: <cover.1591631501.git.sergeyb@tarantool.org>
 <883fd098e177f14c48d2b1b6dc1482aff148e0e3.1591631501.git.sergeyb@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <bd73a954-b679-932b-b649-e66f8722b98f@tarantool.org>
Date: Tue, 9 Jun 2020 01:55:54 +0200
MIME-Version: 1.0
In-Reply-To: <883fd098e177f14c48d2b1b6dc1482aff148e0e3.1591631501.git.sergeyb@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 1/3] test: update unit test lib
 to produce TAP-compliant output
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

> diff --git a/test/unit/unit.h b/test/unit/unit.h
> index 43c301b28..b0f9e7f9f 100644
> --- a/test/unit/unit.h
> +++ b/test/unit/unit.h
> @@ -129,6 +126,16 @@ int check_plan(void);
>  	}						\
>  }
>  
> +#define header() do {                                   \
> +        _space(stdout);                                 \
> +        printf("# *** %s ***\n", __func__);             \
> +} while(0)
> +
> +#define footer() do {                                   \
> +        _space(stdout);                                 \
> +        printf("# *** %s: done ***\n", __func__);       \

All the other alignments use tabs. Lets use tabs here too.

> +} while(0)
> +
>  #if defined(__cplusplus)
>  }
>  #endif /* defined(__cplusplus) */