From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 687B54C883; Sun, 10 Jan 2021 17:30:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 687B54C883 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610289026; bh=sZHOSnHJD/Rzo6K9HjOtibCdL8XdchzZMmxLgpEr9Ng=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=POF+eLRBLQFWM44uTZG2IYWRBx4pqTuFZL2A/n71BjLMy4O5S/tZ5YgInFx27XLa/ N9t6UX3sDQlZTXR4a7zuMFcTklQBUssJ/QPdJl/NS64+JRWa4+jnw5im/+oVxMI41/ bdc9QkmZAZ1JegA6rCZ8C0j/nZs2SZE8/lEkP46o= Received: from fallback15.mail.ru (fallback15.mail.ru [94.100.179.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 514784C883 for ; Sun, 10 Jan 2021 17:30:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 514784C883 Received: from [10.161.55.49] (port=33376 helo=smtpng1.m.smailru.net) by fallback15.m.smailru.net with esmtp (envelope-from ) id 1kybCm-0001qY-Sm for tarantool-patches@dev.tarantool.org; Sun, 10 Jan 2021 16:56:29 +0300 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1kybCk-0002gU-Tx; Sun, 10 Jan 2021 16:56:27 +0300 To: mechanik20051988 , alyapunov@tarantool.org Cc: mechanik20051988 , tarantool-patches@dev.tarantool.org References: <88afdf49f30ccd53898a8925868534479d4836d1.1609239402.git.mechanik20051988@tarantool.org> Message-ID: Date: Sun, 10 Jan 2021 14:56:25 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <88afdf49f30ccd53898a8925868534479d4836d1.1609239402.git.mechanik20051988@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CDDA1A336500443B3AD46BC604C28ED16A00894C459B0CD1B9DCA70879DBCBAA255145F45D098376BE941F610704505C2DAB2D66377DC39A95 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B9FBA884A7C9B8BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063779089FB2CE4EA2908638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCFFDE1474D19ACA27512000B510AEBF4E3D265DF21724B450389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A4D2052C2575E1C58941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B636DA1BED736F9328CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FCF8E90A1DD246484F75ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4931B544F03EFBC4D57A91E23F1B6B78B78B5C8C57E37DE458B4C7702A67D5C3316FA3894348FB808DBAF038BB36E94EA6B574AF45C6390F7469DAA53EE0834AAEE X-B7AD71C0: 6FEFE4C63DFE2D85469AD6E133326EAB664F5199923B286EEC27507A4F178EF710973A06798E20E27C644BF4E41BD140 X-C1DE0DAB: 0D63561A33F958A538D6757A4633AF4CB4055A77A57D5E77A1457EDC14D64643D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34E318F287A436F24C77A0FF811A2FE422553903B810CE1EEDBBEFDBE2CF5D33743054E992D47AEF4C1D7E09C32AA3244C59D4B8E3DEE4FA49B5A7F6EE0E7FC080F26BFA4C8A6946B8927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrM+fB0klCkYiIxn1pRTmsA== X-Mailru-Sender: 689FA8AB762F73937240DDB2502DDB70218A329D1EC0EFDEA664610BCD73A1723841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok X-7564579A: B8F34718100C35BD X-77F55803: 6242723A09DB00B40E5D90E44ABF6C6604BA033ECC7B62DE3D1ACDDC4D7315E2049FFFDB7839CE9E8C4BD7E8152C928B7C7A80F90F7745FC479345F737148E90EF3C861E57241B6B X-7FA49CB5: 0D63561A33F958A504F18E1A1BF42D5CB5496A6A3394DBC75D69CE0472D853C18941B15DA834481FA18204E546F3947C6FF1B927F95F3316F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637006720155ACF5028389733CBF5DBD5E9B5C8C57E37DE458BD96E472CDF7238E04AD6D5ED66289B5278DA827A17800CE79C75F935CA7FC23767F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C3F65C0D82C631A427089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E70227F01F88B6EF2528BD9CCCA9EDD067B1EDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A504F18E1A1BF42D5CB5496A6A3394DBC7EA12728879A543BCD59269BC5F550898D99A6476B3ADF6B4886A5961035A09600383DAD389E261318FB05168BE4CE3AF X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrM+fB0klCkaiw2ptetvnjQ== X-Mailru-MI: 800 X-Mailru-Sender: A5480F10D64C900538CFDDA562D7B4DAB36EF7D330DB609A28FC6730865838C097605B135CE73CA57B4F2DF44667E230E66B5C1DBFD5D09D245155DCEF7B7CF8F7F907C8983C07697402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/4] memtx: implement api for memory allocator selection X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! On 29.12.2020 12:03, mechanik20051988 via Tarantool-patches wrote: > From: mechanik20051988 > > Slab allocator, which is used for tuples allocation, > has a certain disadvantage - it tends to unresolvable > fragmentation on certain workloads (size migration). > New option allows to select the appropriate > allocator if necessary. > > @TarantoolBot document > Title: Add new 'allocator' option > Add new 'allocator' option which allows to > select the appropriate allocator for memtx > tuples if necessary. - Option for what? box.cfg? - What are the option values? - How a user is supposed to choose one? Depending on what? - Is system allocator restricted by the same memory quota? - Does system allocator allocate all the memory at start, like small does? - The option introduction could be a separate commit. Now you did refactoring + new 'feature' in one commit. > Closes #5419 - It does not really 'close' the issue, because at this commit the new allocator type is not implemented. - Besides, this line is below docbot request, which means it will go to the doc ticket. It shouldn't. Taking into account some comments being about system allocator, it seems you should better extract the box.cfg change into a new commit, move it to the end, and add the docbot request to there.