From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3A3D327BB5
	for <tarantool-patches@freelists.org>; Thu,  2 Aug 2018 18:15:13 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 9JWM5erLv1Di for <tarantool-patches@freelists.org>;
	Thu,  2 Aug 2018 18:15:13 -0400 (EDT)
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A73E927BB0
	for <tarantool-patches@freelists.org>; Thu,  2 Aug 2018 18:15:12 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 1/5] sql: prohibit creation of FK
 on unexisting tables
References: <cover.1531443603.git.korablev@tarantool.org>
 <32f36b207de86bf144b16260c9ed434b45cf094c.1531443603.git.korablev@tarantool.org>
 <b46ace50-6ebc-82b2-0bab-6ccc3b378dee@tarantool.org>
 <0176472E-E0CD-41F9-B794-45E02FA54238@tarantool.org>
 <33d5fa73-76a8-9402-e535-4612d7b25c62@tarantool.org>
 <EA969AFF-7424-4BF5-A62E-5BBBA88EA8EC@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <bd06e858-5d5e-6762-82c5-923e38174f8c@tarantool.org>
Date: Fri, 3 Aug 2018 01:15:10 +0300
MIME-Version: 1.0
In-Reply-To: <EA969AFF-7424-4BF5-A62E-5BBBA88EA8EC@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org

Hi! Thanks for the fixes! See 1 comment below and a
separate commit on the branch.

On 01/08/2018 23:54, n.pettik wrote:
> 
>> 1. sql-tap/fkey2.test.lua fails on this commit. Travis fails
>> as well.
> 
> Does it really matter?:) Could you forgive me these fails and
> make me avoid suffering? Anyway, they are completely fixed
> in second patch, but in scope of current patch they can be only
> partially repaired. Hence, it would look like I fix in the second patch
> fixes made in first one..

It had been failing even on the last commit. So it really mattered.

On the second commit it fails now as well.

Please, make it working. It is not okay, that a non-trivial patch
breaks tests, that somehow stop failing after some non-linked
changes.