From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9B07B4765E0 for ; Wed, 23 Dec 2020 15:34:52 +0300 (MSK) References: <6265c0f8-3b96-04db-0bcd-6bb77dc9fe71@tarantool.org> <31bded2b-32e0-5b65-92d1-9ef08415d3fc@tarantool.org> From: Sergey Bronnikov Message-ID: Date: Wed, 23 Dec 2020 15:34:51 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Tarantool-patches] [PATCH 1/4] test: convert print to function and make quotes use consistent List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy , Leonid Vasiliev , tarantool-patches@dev.tarantool.org Cc: alexander.turenko@tarantool.org Hi, On 20.12.2020 19:47, Vladislav Shpilevoy wrote: >> @@ -38,9 +40,9 @@ unpacker.feed(packet) >> # Parse packet >> header = unpacker.unpack() >> body = unpacker.unpack() >> -print 'error code', (header[IPROTO_CODE] & (REQUEST_TYPE_ERROR - 1)) >> -print 'error message: ', body[IPROTO_ERROR] >> -print 'eof:', len(s.recv(1024)) == 0 >> +print("error code {}".format((header[IPROTO_CODE] & (REQUEST_TYPE_ERROR - 1)))) >> +print("error message: {}".format(body[IPROTO_ERROR])) >> +print("eof: {}".format(len(s.recv(1024)) == 0)) >> s.close() >> >> server.admin("box.session.on_connect(nil, f1)") >> diff --git a/test/box-py/bootstrap.result b/test/box-py/bootstrap.result > Please, ensure no .result files are changed. They have nothing to do > with Python strings and quotes. > > Currently you have changed test/box-py/bootstrap.result, > test/box-py/call.result, test/box-py/print.result, > test/replication-py/cluster.result. > > Everything else looks good. > reverted changes that updates .result files, force-pushed.