Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: disallow cast of negative DOUBLE to UNSIGNED
Date: Mon, 26 Jul 2021 21:41:00 +0200	[thread overview]
Message-ID: <bc9fd995-5d25-0479-2674-822caa50e568@tarantool.org> (raw)
In-Reply-To: <4f12b945f7600953437e2eb56a013bc59647757c.1626879871.git.imeevma@gmail.com>

Hi! Thanks for the patch!

On 21.07.2021 17:05, imeevma@tarantool.org wrote:
> Prior to this patch it was possible to use CAST(<double> AS UNSIGNED)
> and get negative result. For example, result of CAST(-1.5 AS UNSIGNED)
> was -1. This patch removes this possiblity. Now such cast can only

possiblity -> possibility

After that LGTM.

  reply	other threads:[~2021-07-26 19:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 15:05 Mergen Imeev via Tarantool-patches
2021-07-26 19:41 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-07-27  7:41 Mergen Imeev via Tarantool-patches
2021-07-28  8:56 ` Timur Safin via Tarantool-patches
2021-07-28 16:24 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc9fd995-5d25-0479-2674-822caa50e568@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 1/1] sql: disallow cast of negative DOUBLE to UNSIGNED' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox