From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8FC1B271FB for ; Tue, 26 Feb 2019 15:16:25 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id huou9QWSGGRa for ; Tue, 26 Feb 2019 15:16:25 -0500 (EST) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id F419226A14 for ; Tue, 26 Feb 2019 15:16:24 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH] sql: LIKE/LENGTH process '\0' References: <15e143f4-3ea7-c7d6-d8ac-8a0e20b76449@tarantool.org> <1560FF96-FECD-4368-8AF8-F8F2AE7696E3@tarantool.org> <07DBA796-6DD4-41DD-8438-104FE3AE05BB@tarantool.org> <4F4E0A7E-199C-4647-A49C-DD0E8A216527@tarantool.org> <8EF5CE57-C6B5-493C-94CC-AA3C88639485@tarantool.org> <7E6CE8AA-512D-4472-9DBD-8159073386C5@tarantool.org> <25649276-74CD-46E7-A1EB-F4CE299E637C@tarantool.org> <427EE913-3E58-413F-A645-DBF83C809334@tarantool.org> <583EC402-D1FF-45C4-B18B-8A06D4362200@tarantool.org> <3377BC01-D943-4D24-A9A2-BA9B9C67EA92@tarantool.org> <044620CF-D255-48D4-9040-3B03846E2852@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Tue, 26 Feb 2019 23:16:22 +0300 MIME-Version: 1.0 In-Reply-To: <044620CF-D255-48D4-9040-3B03846E2852@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, "i.koptelov" Cc: "n.pettik" On 26/02/2019 21:44, i.koptelov wrote: > > >> On 26 Feb 2019, at 20:50, n.pettik wrote: >> >> Won’t bother you with portion of minor comments. >> I’ve pushed them, take a look. If they are OK, just >> squash (but don’t squash last commit) them and >> patch will be OK as well. >> >> Also, I’ve fixed a bit commit message. Add please >> doc request which includes user-visible changes. > Thank you for the fixes! They are OK for me. > Squashed them. Added doc request into the > commit message. > If under a doc request you mean that: https://github.com/tarantool/tarantool/commit/4704f531fc4af0e074410c552a4f3a9d9848c949 then it is incorrect. Please, look at tarantool/docbot for the proper syntax, and check your requests in the online table: https://tarantool-docbot.herokuapp.com If you do not see your request here, then it is incorrect.