From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 679F9469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 19 Nov 2020 14:55:18 +0300 (MSK)
References: <20201113145648.268768-1-gorcunov@gmail.com>
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <bb5bc12e-cf27-b441-2794-63f53e97e6d3@tarantool.org>
Date: Thu, 19 Nov 2020 14:55:14 +0300
MIME-Version: 1.0
In-Reply-To: <20201113145648.268768-1-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH] console: drop unused serpent module
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>

Hi, Cyrill!

thanks for the patch! I propose to get rid of exclude for serpent in 
.luacheckrc too.

On 13.11.2020 17:56, Cyrill Gorcunov wrote:
> Since the commit ae7e210 we use internal serializer
> thus we no longer need serpent code.
>
> The patch removes the references from the source code
> and .gitmodules file, still one might need to run
>
>   | git submodule deinit -f third_party/serpent
>
> manually to clean up the working tree depending
> on local git version.
>
> Closes #5517
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>