From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3F225469711
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  4 Jun 2020 01:52:10 +0300 (MSK)
References: <cover.1590053781.git.sergeyb@tarantool.org>
 <0efa478f960af63eca977f5c3d9615c87197ccc5.1590053781.git.sergeyb@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <bb3f8990-587d-0130-408c-6850126477bb@tarantool.org>
Date: Thu, 4 Jun 2020 00:52:08 +0200
MIME-Version: 1.0
In-Reply-To: <0efa478f960af63eca977f5c3d9615c87197ccc5.1590053781.git.sergeyb@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/2] test: update unit test lib to
 produce TAP-compliant output
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org
Cc: o.piskunov@tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>

Thanks for the patch!

> diff --git a/test/unit/unit.h b/test/unit/unit.h
> index 43c301b28..27879ea98 100644
> --- a/test/unit/unit.h
> +++ b/test/unit/unit.h
> @@ -129,6 +126,16 @@ int check_plan(void);
>  	}						\
>  }
>  
> +#define header() do {				\
> +	_space(stdout);				\
> +	printf("# *** %s ***\n", __func__);	\
> +} while(0)
> +
> +#define footer() do {					\
> +	_space(stdout);					\
> +	printf("# *** %s: done ***\n", __func__);	\

Since alignment is used, lets use it correctly. And align all
the slashes in the same way.

I mean footer and header slashes. Slightly screwed tabs inside
footer and inside header macros are git diff artifacts, no problem
here.

> +} while(0)
> +
>  #if defined(__cplusplus)
>  }
>  #endif /* defined(__cplusplus) */