From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CF9196FC8E; Mon, 26 Apr 2021 12:40:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CF9196FC8E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619430059; bh=xzCa7Gxksq0/hJwhMXNI4xpS770Rn6ht1EY5ctsvkVo=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=mxJDTR7ueQUcn6MZfK2w5E512CWqEHPyxZw9ZfdHww3xYUO0cvBw1CPI6tVbhqsg3 lMFDOETNALNI8FPxfxJ6xzSBj/1tqrX1VdTAqEkXxe8AtUH7LZY3yjkawX6GPMp1IK fvcDs1cw+UuBmQ8C7MPPPNQBRiJ5jc1aiKPkKJ+E= Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F0AED6FC8E for ; Mon, 26 Apr 2021 12:40:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F0AED6FC8E Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1laxjd-0006AJ-Bf; Mon, 26 Apr 2021 12:40:57 +0300 To: Cyrill Gorcunov Cc: Vladislav Shpilevoy , tml References: <20210419083719.29689-1-gorcunov@gmail.com> <20210419083719.29689-2-gorcunov@gmail.com> <68c7c11c-758b-5513-de57-1150c16689d8@tarantool.org> <48231b42-debd-ac18-2a97-bbfa9b4aec5b@tarantool.org> Message-ID: Date: Mon, 26 Apr 2021 12:40:57 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ECFD8CE5F059401062EF72DCC8B8CDABD8D4F98D4AE0C03D182A05F538085040AB6BA0F1C8334A4E6FDF7F2E8C21D862D29F471EC23B5C142D70487404A7229F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2393C4755A27B53EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063779089FB2CE4EA2908638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2E1875135BBE81C7A37D50EAA729C6ED411D9A310A4A5EBA7D2E47CDBA5A96583C09775C1D3CA48CF4964A708C60C975A117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7ABB305BD10C6E5099FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7BB78EDD9C0D8E15ED32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C046DA754BBE08B471CD04E86FAF290E2D7E9C4E3C761E06A71DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6753C3A5E0A5AB5B7089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C97831957FBD225709AE0168DC494EC0BC7860 X-C1DE0DAB: 0D63561A33F958A594A9616E9060B83A335B3E6AA92A667363AB29448667BD71D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C6EC1BD9807109D21160D0ADC05C9378ACE5718FC90968F93DFE090BE9DA4B41E15495DF180235971D7E09C32AA3244C91F03246890D7E2A548A51D41E3516061DD47778AE04E04DFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmUj/IHfqgKevNnv8hFilKw== X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F822B84771806D3B3801577740AECA2AEFE00FE7C94E0C7927424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/3] wal: sanitize wal_mode X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 25.04.2021 16:26, Cyrill Gorcunov пишет: > On Sun, Apr 25, 2021 at 11:08:25AM +0300, Serge Petrenko wrote: >>> +enum wal_mode { >>> + /** >>> + * Do not write data at all. >>> + */ >>> + WAL_NONE, >>> + > ... >> Thanks for the patch! >> >> I'd leave an explicit WAL_NONE = 0. >> I didn't know that enums start at zero, TBH. > Yeah, this is a part of language standart. > >> This would be more readable IMO. > I'll make it so and force push. Thanks a huge for review, guys! Thanks! Please, update the commit message: "- there is no need to set WAN_NONE to 0 explicitly" is not true anymore. LGTM. -- Serge Petrenko