From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EFD6F6EC55; Tue, 13 Jul 2021 00:20:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EFD6F6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1626124852; bh=GWpufdv9NPpmuFXK7yBZhN+8Hw3bq0HJr6KfGbGCCn4=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uQZrFjMvYSpgRRf4Fpa2KWHQSkbZO5+om+XQKymVEBs3roMU3sjRF/Ug6xz4D2rJd 4pXgkDbBoSBAvOuPksdPgPvK98yBgFkkijVwnlHQYu0HYe9me/5kUn41BL5gt6fZ4U 1/vVvK5GElhvXWPW2IZkKpBNPyE0ch9bwXucK9cM= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C54DD6EC55 for ; Tue, 13 Jul 2021 00:20:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C54DD6EC55 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1m33Lg-0005Sv-4r; Tue, 13 Jul 2021 00:20:20 +0300 To: Cyrill Gorcunov References: <20210710222803.253251-1-gorcunov@gmail.com> <187d1ae2-99cb-50d4-d5b4-18aa6c5f5546@tarantool.org> <36639f07-5c56-5c94-d563-0862135d0ea9@tarantool.org> Message-ID: Date: Mon, 12 Jul 2021 23:20:19 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD97BB0EF39AD2B33D52181556DE8CA6AFBAFE18027C1DA7DF9182A05F53808504049CCDAE63A82386A30FD6BE563C24FB5EF2A998FEB2365DF13640B5C24E1C5F2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7484B509D84968742EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C83F54BD885518138638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D819321A310EB4DE59A6AFADA1FE853E43117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC6FC43C45D3E35E8FA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10F618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A51C1E433C2A4A4AE4F3C563E45A3514DF57EDC73F236DFF20D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA759DD14948C6BCD3BA410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AB80C45F81B80D6330804C5B7A4C79FFD75129D9457ECFBC81A7AE55C553A25101F48CE15B0FAA891D7E09C32AA3244C7E1EAD8FA518013681CE63A616849B053A76366E8A9DE7CAFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojAZDAgpmGsvZleBYMUPldNw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DB91EE71BFC4E273BB1B50F7492D4EEA33841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] limbo: introduce request processing hooks X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 12.07.2021 10:12, Cyrill Gorcunov wrote: > On Mon, Jul 12, 2021 at 10:04:56AM +0200, Vladislav Shpilevoy wrote: >>> >>> And if we filter before the WAL write, we need the second vclock, which >>> Cyrill has introduced. >> >> Why do you need a second vclock? Why can't you just filter by the >> existing vclock and update it after WAL write like now? > > Because the phases are no longer atomic. We can pass "filter" stage, > update our terms, Сложность твоего патча исходит из этого предложения - на filter stage ты почему-то update terms. Это уже не filter, если ты начинаешь че-то менять в лимбе до записи в WAL. Я пытаюсь от тебя добиться ответа, зачем так. Если можно не менять до записи в WAL ничего, и все равно нормально фильтровать. Фильтровать по настоящему, не меняя ничего. Я про латч в другом письме написал.