From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1AD30469719 for ; Sat, 15 Feb 2020 22:02:24 +0300 (MSK) References: From: Oleg Babin Message-ID: Date: Sat, 15 Feb 2020 22:02:21 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 0/2] box.tuple.* cleanup List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, alexander.turenko@tarantool.org, imun@tarantool.org Hi! Thanks for your patch! On 15/02/2020 21:08, Vladislav Shpilevoy wrote: > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4662-fiber-storage-leak > Issue: https://github.com/tarantool/tarantool/issues/4662 > I think you made a mistake and your branch is https://github.com/tarantool/tarantool/compare/gerold103/gh-4684-tuple-bless-crash and issue is #4684 Also I've found that "next", "ipairs", "slice" and "upsert" are not documented as well. Patches LGTM.