From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 20CE2469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 13 Oct 2020 17:05:29 +0300 (MSK)
References: <20201013133418.34422-1-sergepetrenko@tarantool.org>
 <20201013140155.GE14048@grain>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <ba3261b7-9879-47ae-ac07-ef45aa938718@tarantool.org>
Date: Tue, 13 Oct 2020 17:05:27 +0300
MIME-Version: 1.0
In-Reply-To: <20201013140155.GE14048@grain>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH] feedback_daemon: add synchro
 replication usage reporting
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org


13.10.2020 17:01, Cyrill Gorcunov пишет:
> On Tue, Oct 13, 2020 at 04:34:18PM +0300, Serge Petrenko wrote:
>>   
>> +local function fill_in_options(feedback)
>> +    local options = {}
>> +    options.election_mode = box.cfg.election_mode
>> +    options.synchro_quorum = box.cfg.replication_synchro_quorum
>> +    feedback.options = options
>> +end
> Maybe be we could just get rid of local variable here?
Yes, sure. I'll do it together with other fixes, if any.
>
> local function fill_in_options(feedback)
>      feedback.options = {
>          ['election_mode']   = box.cfg.election_mode,
>          ['synchro_quorum']  = box.cfg.replication_synchro_quorum,
>      }
> end
>
> Not insisting at all just a thought.

-- 
Serge Petrenko