From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 25FDB25024 for ; Thu, 5 Jul 2018 12:11:40 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z4AuId-QuDWP for ; Thu, 5 Jul 2018 12:11:40 -0400 (EDT) Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C41D9269EE for ; Thu, 5 Jul 2018 12:11:39 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 2/2] sql: remove usless sqlite3NestedParse function References: <444b91093cc6ea1648f0e8bdd9b0923694ca3f8a.1530724375.git.kshcherbatov@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Thu, 5 Jul 2018 19:11:37 +0300 MIME-Version: 1.0 In-Reply-To: <444b91093cc6ea1648f0e8bdd9b0923694ca3f8a.1530724375.git.kshcherbatov@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org Thanks for the patch! Please, finish it. You did not remove Parse.nested and PARSE_TAIL. And maybe something else. On 04/07/2018 20:17, Kirill Shcherbatov wrote: > As sqlite3NestedParse become totaly useless, let's > remove unreacheble code and all mentioning. > > Resolves #3496. > --- > src/box/sql/build.c | 40 ---------------------------------------- > src/box/sql/delete.c | 6 +----- > src/box/sql/insert.c | 6 +----- > src/box/sql/sqliteInt.h | 1 - > src/box/sql/update.c | 6 +----- > 5 files changed, 3 insertions(+), 56 deletions(-) >