From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BA07542EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 11 Jun 2020 20:06:51 +0300 (MSK)
References: <cover.1591371404.git.k.sosnin@tarantool.org>
 <473ff051ab9075f28732c28396d4465460e4a130.1591371404.git.k.sosnin@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <b9973a24-3cfe-6dfb-0373-dd34771c15c3@tarantool.org>
Date: Thu, 11 Jun 2020 19:06:50 +0200
MIME-Version: 1.0
In-Reply-To: <473ff051ab9075f28732c28396d4465460e4a130.1591371404.git.k.sosnin@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/2] Add IsWhole method for checking
 the fractional part of a number
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>, tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org

I guess you rather need name IsInt. 'Whole' has a different
meaning.

Why do you need it, btw? Why decNumberToInt64() and decNumberToUInt64()
are not enough? The only usecase for this new function I can
imagine is an attempt to shrink a decimal value into a normal integer.
Which are either int64_t or uint64_t.