From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id CC7C02F582
	for <tarantool-patches@freelists.org>; Tue, 18 Jun 2019 16:39:37 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 4ef19xvCCuGN for <tarantool-patches@freelists.org>;
	Tue, 18 Jun 2019 16:39:37 -0400 (EDT)
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2E2542D78B
	for <tarantool-patches@freelists.org>; Tue, 18 Jun 2019 16:39:37 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v1 18/28] sql: remove
 SQL_CONSTRAINT errcode
References: <cover.1560174553.git.imeevma@gmail.com>
 <40cba82136f5c06632922856f95294616a475b74.1560174553.git.imeevma@gmail.com>
 <a3433fb4-dbb9-1341-0485-d1365a1dab64@tarantool.org>
 <20190615100010.GF32365@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <b91c98a7-81b8-83fd-239b-148965431138@tarantool.org>
Date: Tue, 18 Jun 2019 22:40:04 +0200
MIME-Version: 1.0
In-Reply-To: <20190615100010.GF32365@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@freelists.org

Hi! Thanks for the patch!

On 15/06/2019 12:00, Mergen Imeev wrote:
> On Fri, Jun 14, 2019 at 12:24:55AM +0200, Vladislav Shpilevoy wrote:
>> Thanks for the patch!
>>
>> I've found 'sql_CONSTRAINT_UNIQUE' in sql-tap/unique.test.lua

It is still here. Please, fix.

>> on line 229. These tests are disabled by 'if 0 > 0', but another
>> comment says, that the issue #2495 fix should have enabled them
>> back. We need to either resurrect these tests, or drop them.
>>
>> Consider my review fixes below and on the branch
>> in a separate commit.
>>