From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp20.mail.ru (smtp20.mail.ru [94.100.179.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D8C46469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 18 May 2020 15:03:55 +0300 (MSK)
References: <20200512135052.221379-1-gorcunov@gmail.com>
 <20200512135052.221379-2-gorcunov@gmail.com>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <b8d83f41-31b4-0ab3-0850-7f6bd9ce8fdf@tarantool.org>
Date: Mon, 18 May 2020 15:03:54 +0300
MIME-Version: 1.0
In-Reply-To: <20200512135052.221379-2-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/7] box/console:
 console_session_vtab -- use designated initialization
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

Hi! Thanks for your patch. LGTM.

On 12/05/2020 16:50, Cyrill Gorcunov wrote:
> For better maintainance.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>   src/box/lua/console.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/box/lua/console.c b/src/box/lua/console.c
> index b941f50c6..d937d684e 100644
> --- a/src/box/lua/console.c
> +++ b/src/box/lua/console.c
> @@ -582,9 +582,9 @@ tarantool_lua_console_init(struct lua_State *L)
>   	 */
>   	lua_setfield(L, -2, "formatter");
>   	struct session_vtab console_session_vtab = {
> -		/* .push = */ console_session_push,
> -		/* .fd = */ console_session_fd,
> -		/* .sync = */ generic_session_sync,
> +		.push	= console_session_push,
> +		.fd	= console_session_fd,
> +		.sync	= generic_session_sync,
>   	};
>   	session_vtab_registry[SESSION_TYPE_CONSOLE] = console_session_vtab;
>   	session_vtab_registry[SESSION_TYPE_REPL] = console_session_vtab;
>