From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1BF7156A9A3; Tue, 8 Aug 2023 11:19:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1BF7156A9A3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1691482741; bh=wT5sTIGLlz+EyzpnzXYN1qD/GDdRWE0a8mMKXHAZlPY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=PC76qBcEufar5l9poFp9o5ZcfcPEOiKvCRtQASds1xMWCry3aQJk6amjDc3rFJB48 WgwfKPSBkMx7nEKxHPsJ+mfwIKQKdCr/vRoXebO3aOoaE2JcKo5BwACWh5zVTCglh/ OyOgVsAwnrJd/mzx78YSeu2Wz/8C4Aonr48ifMcA= Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [95.163.41.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B057D56A9A3 for ; Tue, 8 Aug 2023 11:18:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B057D56A9A3 Received: by smtp30.i.mail.ru with esmtpa (envelope-from ) id 1qTHve-009siT-0P; Tue, 08 Aug 2023 11:18:58 +0300 Message-ID: Date: Tue, 8 Aug 2023 11:18:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Igor Munkin References: <2f20f91c-1336-b34b-6681-3947e96b486d@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC8BEB87106826C459512B2000DD660D84D182A05F53808504058A5583F7876B35EF9E6F5CF207AA4131CF06925989C4B99FED2DEB19A29BC47 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE771540F9ECFC94C4BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D3219148F76DED538638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D83F0086346E2390BC6A19E3ACB78703AC117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCECADA55FE5B58BB7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C65AC60A1F0286FE618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B19735652A29929C6C4AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C30AA277257C6A5E3D76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CC415C329B279CF9D43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A50D573208BCB2A94115795DC23BB4A5B9EE6E75F450048A99F87CCE6106E1FC07E67D4AC08A07B9B0672DC5A730DF09D2CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34AAC3D1FDB34D048861256EE7C410D6AF53AEC1986FB5A66A1ACDED0F30CF216C03D22F8B53D8D6A91D7E09C32AA3244CCAFE7539770AA1A79409E799FBC524AA51E887DA02A9F7BF85A42E4C463514DC5DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj/xSHLV4ZQPt2DIr8rEf9Lw== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76913A4A87A14885AF7F9E6F5CF207AA413BE4EBEF89FC7D6FAEBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks, Igor! LGTM On 8/7/23 16:35, Igor Munkin wrote: > OK, this is sad. Again, something is not covered "by default" in CI. > All problems are described below. > > The most important, flake8 is too old in our Linux repos (see below): | > flake8 is already the newest version (3.7.9-2). Hence, I decided to fix > the version to 6.1.0 as the newest one for the following reasons: > * New heuristics are added (AFAIR, you used 6.0.0 below), so more > errors are found. > * Unexpected upgrade to the new version of flake8 can lead to new error > errors, so CI can fail for no reason. Hence pinning the version > provides more control for CI (and this is horosho). > > Here is the diff: > > ================================================================================ > > diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml > index 2d227118..b4e66f53 100644 > --- a/.github/workflows/lint.yml > +++ b/.github/workflows/lint.yml > @@ -41,8 +41,9 @@ jobs: > run: | > # TODO: Move this step to a separate action. > sudo apt -y update > - sudo apt -y install cmake ninja-build lua5.1 luarocks flake8 > + sudo apt -y install cmake ninja-build lua5.1 luarocks > sudo luarocks install luacheck > + sudo pip3 install flake8==6.1.0 > # Set CMAKE_BUILD_PARALLEL_LEVEL environment variable to > # limit the number of parallel jobs for build/test step. > echo CMAKE_BUILD_PARALLEL_LEVEL=$(($(nproc) + 1)) | tee -a $GITHUB_ENV > > ================================================================================ > > As a result of this change, all the errors mentioned below are reported > by our CI[1]. OK, what about the errors per se (see below). > > On 03.08.23, Sergey Bronnikov wrote: >> LuaJIT-lint reports 4 warnings: >> >> >> Total: 0 warnings / 0 errors in 108 files >> Built target LuaJIT-luacheck >> /home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/luajit-gdb.py:330:11: >> E275 missing whitespace after keyword >> /home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/luajit-gdb.py:338:10: >> E275 missing whitespace after keyword >> /home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/luajit_lldb.py:391:10: >> E275 missing whitespace after keyword >> /home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/luajit_lldb.py:519:11: >> E275 missing whitespace after keyword > The 1st and the 3rd errors are not just style issues, but the actual > errors. is a statement in Python, so the parenthesis are > considered as a tuple constructor. Fixed it in scope of the separate > commit (will send in reply to this message). > > The remaining issues relates to missing whitespace, so I fixed it the > same way all other style violations were fixed (will also send the patch > in reply to this message). > >> On 8/3/23 17:23, Sergey Bronnikov via Tarantool-patches wrote: >>> Hi, Igor >>> >>> >>> thanks for the patch! see my comments >>> >> >> > [1]: https://github.com/tarantool/luajit/actions/runs/5785548226/job/15678397206 >