From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0E9B6469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 18 May 2020 18:25:10 +0300 (MSK)
References: <cover.1589240704.git.v.shpilevoy@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <b88e9749-e075-4139-7fe5-e93790631bc5@tarantool.org>
Date: Mon, 18 May 2020 18:25:09 +0300
MIME-Version: 1.0
In-Reply-To: <cover.1589240704.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH 0/5] mp_snprint() and mp_fprint()
	for decimal, uuid, error
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org, gorcunov@gmail.com, korablev@tarantool.org

Hi! Thanks for the patchset!

12.05.2020 02:45, Vladislav Shpilevoy пишет:
> The patchset makes msgpuck functions mp_snprint() and mp_fprint()
> nicely serialize MP_DECIMAL, MP_UUID, and MP_ERROR objects.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4719-mp_print-ext
> Issue: https://github.com/tarantool/tarantool/issues/4719
>
> Vladislav Shpilevoy (5):
>    msgpuck: bump version to enable extension printer
>    decimal: provide MP_DECIMAL extension serializer
>    uuid: provide MP_UUID extension serializer
>    error: provide MP_ERROR extension serializer
>    msgpuck: activate MP_EXT custom serializers
>
>   src/box/CMakeLists.txt    |   1 +
>   src/box/box.cc            |   2 +
>   src/box/mp_error.cc       | 161 ++++++++++++++++++++++-
>   src/box/mp_error.h        |  29 ++++
>   src/box/msgpack.c         |  78 +++++++++++
>   src/box/msgpack.h         |  41 ++++++
>   src/lib/core/mp_decimal.c |  18 +++
>   src/lib/core/mp_decimal.h |  27 ++++
>   src/lib/msgpuck           |   2 +-
>   src/lib/uuid/mp_uuid.c    |  18 +++
>   src/lib/uuid/mp_uuid.h    |  27 ++++
>   test/unit/decimal.c       |  63 ++++++++-
>   test/unit/decimal.result  |  11 +-
>   test/unit/mp_error.cc     | 270 +++++++++++++++++++++++++++++++++++++-
>   test/unit/mp_error.result |  72 +++++++++-
>   test/unit/msgpack.result  |  17 ++-
>   test/unit/uuid.c          |  64 ++++++++-
>   test/unit/uuid.result     |  11 +-
>   18 files changed, 900 insertions(+), 12 deletions(-)
>   create mode 100644 src/box/msgpack.c
>   create mode 100644 src/box/msgpack.h

LGTM

-- 
Serge Petrenko