From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A32D728A71 for ; Tue, 28 Aug 2018 02:46:18 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zplN3BM9vSN0 for ; Tue, 28 Aug 2018 02:46:18 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D5B3128A40 for ; Tue, 28 Aug 2018 02:46:17 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 2/2] sql: remove struct Enc References: <388a4c514161fb19233e3185e6f211d33fd7f7f3.1535367103.git.kshcherbatov@tarantool.org> From: Kirill Shcherbatov Message-ID: Date: Tue, 28 Aug 2018 09:46:14 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Vladislav Shpilevoy > Thanks for the patch! See 7 comments below and a > commit on the branch. Hi. Thank you for review > 1. Double include of region.h. done. > 2. Static. fixed. > 3. No comment. /** * Encode index options @opts into message pack with @stream. * @param stream Message Pack Stream to use on encode. * @param opts Index options to encode. */ static void mpstream_encode_index_opts(struct mpstream *stream, struct index_opts *opts) > 4. Finish a sentence with the dot. Btw the comment > is not related to the code. Below you do not whether > the index is unique or not. > 5. "Did't defined" - corrupted phrase. Rather "did't define". > But the whole comment looks strange as well as the previous, > and out of its place. Just remove it. You know, I've just copied existed peace of code with all comments. I've get rid off those two comments at all now. > 6. If 'raw == NULL' you still try to use it in box_update. My fault. Fixed. > 7. Here https://github.com/tarantool/tarantool/commit/0d8b0c5641ec4c27547b1d0121bb1e0a641b149b > I see changes not relevant to this patch and not presented in the > email. I paste them bellow: Done.