From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 520A46EC5F; Thu, 15 Apr 2021 01:59:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 520A46EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618441140; bh=fLxoQLaklxiCHBY9OHt2gbjYHtL5HvPY/pADJbV4E+g=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=WKMqPAURR2kmQ0UphdLU+oZhWQ5wcFT/jwfzsg72M9h8QEsQs5DuYdcU9dSUWq5Ea IZd6TwEd1crzX3KZwWl0WyitGoJ4Fqk6N/cElgWUG8CQ7VB2Fk3l1E5ztwNlJ0Bd9T /ert5oXhIk6eTK9auU8amTw6/yxxCldy/E84Lq/0= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9CFB26EC5F for ; Thu, 15 Apr 2021 01:58:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9CFB26EC5F Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lWoTK-0007CU-TD; Thu, 15 Apr 2021 01:58:59 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <8e694c5dbed5b36828d97729d4d6c4dac0d6a440.1617984948.git.imeevma@gmail.com> Message-ID: Date: Thu, 15 Apr 2021 00:58:57 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <8e694c5dbed5b36828d97729d4d6c4dac0d6a440.1617984948.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480B1C8842CE613979723F2FB4628545A35182A05F538085040FFC1338CE830E66F766EF644002726E9ADB43474FF5C23C51848B9D47262AA8F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE704FFE27C31EF363AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637651D61939D0B3DD78638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2E916C553FA749C9046A43C12334DA44C07164437C8F97EC6D2E47CDBA5A96583C09775C1D3CA48CF27ED053E960B195E117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735C6C49853BF2B2AEEC4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831EB86C19480EE7EFED3DF300CDFC134A3 X-C1DE0DAB: 0D63561A33F958A540BE9D056A2266E9D46CEB9916724D017C99CC552F6606BFD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D6AC337C1E637B8A3FDB422D99769C4A23A69CE5772A9573FEF6176EEC373222C3319F888989F4CF1D7E09C32AA3244C8EBA0E4D29FD251EE88601CE550344A7725D5B54B2FE4575FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrcJA+pXcDunwZiG3jHV5AQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822586EEFC591E34516BA56AB6C431687B83841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 17/52] sql: remove sql_column_to_messagepack() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" I appreciate the work you did here! > diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h > index e075224c6..259ba3833 100644 > --- a/src/box/sql/sqlInt.h > +++ b/src/box/sql/sqlInt.h > @@ -471,8 +461,9 @@ const unsigned char * > sql_column_text(sql_stmt *, > int iCol); > > -enum mp_type > -sql_column_type(sql_stmt *stmt, int field_no); > +char * > +sql_result_to_msgpack(struct sql_stmt *stmt, uint32_t *tuple_size, > + struct region *region); I noticed just now - this is a method of sql_stmt, and therefore must be called 'sql_stmt_result_to_msgpack()'. With 'sql_stmt' prefix.