From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 03BC022BD9 for ; Mon, 1 Jul 2019 17:52:09 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J5oRS7pwM1q3 for ; Mon, 1 Jul 2019 17:52:08 -0400 (EDT) Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B726E22B80 for ; Mon, 1 Jul 2019 17:52:08 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 5/6] sql: introduce extended range for INTEGER type References: <047750c3-04ab-0805-944e-c5afd5781aa8@tarantool.org> <7EC98960-872A-418E-9E40-F4DBC266ACB0@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Mon, 1 Jul 2019 23:53:05 +0200 MIME-Version: 1.0 In-Reply-To: <7EC98960-872A-418E-9E40-F4DBC266ACB0@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "n.pettik" , tarantool-patches@freelists.org Thanks for the fixes! Consider new one below, and on the branch in a separate commit. ===================================================== diff --git a/src/box/sql/expr.c b/src/box/sql/expr.c index fca22c371..8854fec06 100644 --- a/src/box/sql/expr.c +++ b/src/box/sql/expr.c @@ -3311,8 +3311,7 @@ expr_code_int(struct Parse *parse, struct Expr *expr, bool is_neg, if (sql_atoi64(z, &value, &unused, len) != 0 || (is_neg && (uint64_t) value > (uint64_t) INT64_MAX + 1)) { int_overflow: - diag_set(ClientError, ER_INT_LITERAL_MAX, sign, z, - INT64_MIN, UINT64_MAX); + diag_set(ClientError, ER_INT_LITERAL_MAX, sign, z); parse->is_aborted = true; return; }