From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E4FAC27961 for ; Mon, 13 Aug 2018 16:24:29 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Swd3LHgKeJpd for ; Mon, 13 Aug 2018 16:24:29 -0400 (EDT) Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9A54428809 for ; Mon, 13 Aug 2018 16:24:29 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 08/10] sql: use secondary indexes to process OP_Delete References: <2cb98faa8403229595d38b55ca6c8bd790bd9c81.1534001739.git.korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Mon, 13 Aug 2018 23:24:27 +0300 MIME-Version: 1.0 In-Reply-To: <2cb98faa8403229595d38b55ca6c8bd790bd9c81.1534001739.git.korablev@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Nikita Pettik , tarantool-patches@freelists.org Thanks for the patch! I have pushed my review fixes in a separate commit. On 12/08/2018 17:13, Nikita Pettik wrote: > Before this patch OP_Delete used only primary index to delete entry. > Since it already operates on cursor, which in turn can be open on > secondary index, lets pass index id to internal routine to use it. > This is required in order to remove duplicates from secondary indexes > while processing INSERT/UPDATE OR REPLACE statement. > --- > src/box/sql.c | 17 +++++------------ > src/box/sql/tarantoolInt.h | 16 +++++++++++++++- > src/box/sql/vdbe.c | 2 +- > 3 files changed, 21 insertions(+), 14 deletions(-) >