From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1316E45C304
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 11 Dec 2020 14:12:57 +0300 (MSK)
References: <20201210161832.729439-1-gorcunov@gmail.com>
 <20201210161832.729439-4-gorcunov@gmail.com>
 <f73f257f-b87f-bc88-d2e8-3028d13866ae@tarantool.org>
 <20201211103804.GD544004@grain>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <b7c190d7-ee02-d2b8-0d78-6d03a986abb8@tarantool.org>
Date: Fri, 11 Dec 2020 14:12:55 +0300
MIME-Version: 1.0
In-Reply-To: <20201211103804.GD544004@grain>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH v4 3/4] crash: move fatal signal
	handling in
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>, tml <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>


11.12.2020 13:38, Cyrill Gorcunov пишет:
> On Fri, Dec 11, 2020 at 12:31:18PM +0300, Serge Petrenko wrote:
>>> --- /dev/null
>>> +++ b/src/lib/core/crash.c
>>> @@ -0,0 +1,291 @@
>>> +/*
>>> + * SPDX-License-Identifier: BSD-2-Clause
>>> + *
>>> + * Copyright 2010-2020, Tarantool AUTHORS, please see AUTHORS file.
>>
>> I haven't seen us using such a license before.
>> It must be fine, I'm just not familiar with this.
> We've been discussing this spdx reference in chat and I've got no
> rejection so far. So I think using short ref a way more convenient
> instead of pushing the big header to each file.
>
> https://spdx.org/licenses/
> https://en.wikipedia.org/wiki/Software_Package_Data_Exchange


Ok, I see. Discard this comment then.


>>> +static void
>>> +crash_report_stderr(struct crash_info *cinfo)
>>> +{
>>> +	if (cinfo->signo == SIGSEGV) {
>>> +		fprintf(stderr, "Segmentation fault\n");
>>> +		const char *signal_code_repr = 0;
>>
>> Please use NULL for pointers.
> Both comments are fixed and force pushed. Thanks!

-- 
Serge Petrenko