From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0FA24C63FB0; Wed, 25 Sep 2024 10:22:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0FA24C63FB0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1727248938; bh=KfZP+xOu0F2O/p1FM+sLiXNsRau4ywog+JTNyly3mTU=; h=Date:To:References:Cc:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=UndVwReDPNzIHGkfyCgwhB/ySkTNRHV9WiAvsbY8k4vEr9HRZpCaIDvlkqe0crKcY 9JurIpOk0XGIQ6gj0m6lPRWQujodFgUoRM/KKgX6qbU1yQ0ra5b+GNZbTnARmke33J hDMHUMs5tgnqQxe8wK2+zN4VklcXdD6HzE6YRGPE= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5EC4A64D5E7 for ; Wed, 25 Sep 2024 10:22:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5EC4A64D5E7 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1stMLk-0000000G3mk-00y3; Wed, 25 Sep 2024 10:22:12 +0300 Content-Type: multipart/alternative; boundary="------------Eepnp8FHJ0sm3ZFjbTIN0oUz" Message-ID: Date: Wed, 25 Sep 2024 10:22:11 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun , Maxim Kokryashkin References: Content-Language: en-US Cc: tarantool-patches In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD968D81A599CAF0ABB73F766E43C204C3208079ED5FC033AD7182A05F5380850408069AE741611BF0A479CDAE959BF6424C2D335F99FB8DBA8E02CB06914B76F6ADABA3F7B65B49C8A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75AD53DF1D86BACA3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637367CCE42412B8BE38638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D87CC5FA356C1E735967A241B811D3F4162FD1E17E0E611703CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637E603D20A273AEC4F389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637B2737265289038E2D32BA5DBAC0009BE395957E7521B51C2330BD67F2E7D9AF1090A508E0FED6299176DF2183F8FC7C0500AC0B2F9B62304B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B8E48D8FAA4D20A9F75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5FBABFFD30AAC909F5002B1117B3ED6969F205D0D9F07CDF203803A57F48E4E5A823CB91A9FED034534781492E4B8EEAD5DF1C2DF01CE7211BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D346AD04FDA812EEFF122D24F869FF0138AA9FCB8C39DFC7655019841982AA214D77236F35AC39D2BB81D7E09C32AA3244CB3DDED2203FBDD425DAF20B2795D9467143207A3C7C691DDEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojaRHbkpqrpaNFzKh0v4tlaQ== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D61402A2297CF59E738F4D6D9EAB72702064EAB6970DD2ECF533B0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 4/7] test: shrink LUA_PATH environment variable X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------Eepnp8FHJ0sm3ZFjbTIN0oUz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, On 25.09.2024 10:19, Sergey Kaplun wrote: > On 24.09.24, Sergey Kaplun via Tarantool-patches wrote: >> Hi, Sergey! >> >> On 24.09.24, Sergey Bronnikov wrote: >>> Hi, Sergey, >>> >>> >>> On 24.09.2024 13:29, Sergey Kaplun wrote: >>>> This patch removes the default adding of the tools directory to the >>>> LUA_PATH. Now it is done only for profilers tests. >>>> >>>> Part of tarantool/tarantool#9898 >>>> --- >> >> >>>> @@ -163,4 +161,12 @@ foreach(test_path ${tests}) >>>> LABELS ${TEST_SUITE_NAME} >>>> DEPENDS tarantool-tests-deps >>>> ) >>>> + >>>> + # The part of the profilers toolchain is located in the >>>> + # directory, so LUA_PATH needs to be updated. >>>> + if(test_name MATCHES "^profilers") >>>> + AppendTestEnvVar(${test_title} >>>> + LUA_PATH "${PROJECT_SOURCE_DIR}/tools/?.lua\;" >>>> + ) >>>> + endif() >>>> endforeach() >>> AFAIR, we decided to move the last hunk to profilers/CMakeLists.txt. >> I don't remember that, unfortunately. Also, may be it is better that >> this cycle handles all tests? Otherwise, we should scan that directory >> again with constructing test_title again. This is why we decided to move >> it in the cycle instead of the child [1]. >> Okay, let's leave it without changes. LGTM >> [1]:https://lists.tarantool.org/tarantool-patches/c22c7bc2-ddaa-4b22-83ae-edba3ce73dd6@tarantool.org/T/#u >> >> -- >> Best regards, >> Sergey Kaplun --------------Eepnp8FHJ0sm3ZFjbTIN0oUz Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,


On 25.09.2024 10:19, Sergey Kaplun wrote:
On 24.09.24, Sergey Kaplun via Tarantool-patches wrote:

Hi, Sergey!

On 24.09.24, Sergey Bronnikov wrote:

Hi, Sergey,


On 24.09.2024 13:29, Sergey Kaplun wrote:

This patch removes the default adding of the tools directory to the
LUA_PATH. Now it is done only for profilers tests.

Part of tarantool/tarantool#9898
---

<snipped>


@@ -163,4 +161,12 @@ foreach(test_path ${tests})
      LABELS ${TEST_SUITE_NAME}
      DEPENDS tarantool-tests-deps
    )
+
+  # The part of the profilers toolchain is located in the <tools/>
+  # directory, so LUA_PATH needs to be updated.
+  if(test_name MATCHES "^profilers")
+    AppendTestEnvVar(${test_title}
+      LUA_PATH "${PROJECT_SOURCE_DIR}/tools/?.lua\;"
+    )
+  endif()
  endforeach()

AFAIR, we decided to move the last hunk to profilers/CMakeLists.txt.

I don't remember that, unfortunately. Also, may be it is better that
this cycle handles all tests? Otherwise, we should scan that directory
again with constructing test_title again. This is why we decided to move
it in the cycle instead of the child <CMakeLists.txt> [1].

Okay, let's leave it without changes.

LGTM


        

        
[1]: https://lists.tarantool.org/tarantool-patches/c22c7bc2-ddaa-4b22-83ae-edba3ce73dd6@tarantool.org/T/#u

-- 
Best regards,
Sergey Kaplun


      

      

    

  
  


--------------Eepnp8FHJ0sm3ZFjbTIN0oUz--