From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CCFE34429A8 for ; Sat, 19 Oct 2019 16:28:20 +0300 (MSK) References: <20191018134710.69147-1-korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Sat, 19 Oct 2019 15:33:29 +0200 MIME-Version: 1.0 In-Reply-To: <20191018134710.69147-1-korablev@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [tarantool-patches] [PATCH] sql: remove expmask from prepared statement List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik , tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org, Kirill Yukhin Hi! Thanks for the patch! LGTM. On 18/10/2019 15:47, Nikita Pettik wrote: > expmask indicated necessity to recompile statement after parameter was > bound: it might turn out that parameter can affect query plan. However, > part of this mechanism has been removed long ago as a SQLite's legacy. > In its current state expmask is likely to be useless and assertions > involving it are obviously unsuitable. This patch completely removes > expmask and related routines. > > Closes #4566 > --- > Branch: https://github.com/tarantool/tarantool/tree/np/gh-4566-remove-exp-mask > Issue: https://github.com/tarantool/tarantool/issues/4566 > > src/box/sql/vdbe.h | 1 - > src/box/sql/vdbeInt.h | 1 - > src/box/sql/vdbeapi.c | 19 ------------------- > src/box/sql/vdbeaux.c | 16 ---------------- > src/box/sql/vdbemem.c | 1 - > src/box/sql/whereexpr.c | 2 -- > test/sql/bind.result | 32 ++++++++++++++++++++++++++++++++ > test/sql/bind.test.lua | 9 +++++++++ > 8 files changed, 41 insertions(+), 40 deletions(-) >