From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7C689469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 20 Feb 2020 23:30:53 +0300 (MSK)
References: <cover.1580856721.git.v.shpilevoy@tarantool.org>
 <20200220061505.kzbzgcgyjx6b4nkp@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <b65e05b2-9506-37b2-061e-97684ce8f0c8@tarantool.org>
Date: Thu, 20 Feb 2020 21:30:50 +0100
MIME-Version: 1.0
In-Reply-To: <20200220061505.kzbzgcgyjx6b4nkp@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH v2 0/4] Don't truncate float in
	update
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

Why did you decide not to push it into 2.2 and 1.10? This is
a bug, and it exists in these versions too.

On 20/02/2020 07:15, Kirill Yukhin wrote:
> Hello,
> 
> On 04 фев 23:53, Vladislav Shpilevoy wrote:
>> The patchset fixes float value truncation in
>> tuple/space:update/upsert. First commit fixes the actual issue,
>> but introduces another bug that a float value can be stored into a
>> field having double type in its format.
>>
>> The rest 3 commits fix this new bug.
>>
>> However, there is an alternative how these 3 could be done. My
>> solution is that I calculate the result types in
>> xrow_update_*_store() functions. Because of that I don't know the
>> types during xrow_update_*_sizeof(), and it needs to return the
>> maximal possible size instead of exact size. The alternative is to
>> calculate types during sizeof. It would allow to return the exact
>> size. But it also would complicate the code. I can implement this
>> option if it looks better.
>>
>> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4701-update-float-truncate
>> Issue: https://github.com/tarantool/tarantool/issues/4701
> 
> LGTM. I've checked your patchset into 2.3 and master.
> 
> --
> Regards, Kirill Yukhin
>