From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 65AEC2A7EA for ; Thu, 21 Mar 2019 09:31:30 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rsHpXRCKW0kI for ; Thu, 21 Mar 2019 09:31:30 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1481D2A7E9 for ; Thu, 21 Mar 2019 09:31:30 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 2/2] schema: add exact field count to SQL stat spaces References: From: Vladislav Shpilevoy Message-ID: Date: Thu, 21 Mar 2019 16:31:27 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Nikita Pettik , tarantool-patches@freelists.org On that branch tests sql-tap/gh2548-select-compound-limit.test.lua and sql-tap/gh2250-trigger-chain-limit.test.lua fail. On 19/03/2019 02:51, Nikita Pettik wrote: > As a rule, system spaces don't feature exact field count. There is a > reason for that: almost all of them have on replace triggers, which > extract data from tuple and verify it. However, _sql_stat1 and > _sql_stat4 spaces containing SQL specific statistics don't have such > triggers. Hence, one can insert tuple to this space with greater number > of fields, than format says. To prevent this, let's explicitly set exact > field count to number of fields in format. > --- > src/box/bootstrap.snap | Bin 1831 -> 1840 bytes > src/box/lua/upgrade.lua | 29 ++++++++++++++++++++++++++++- > test/box-py/bootstrap.result | 6 +++--- > test/box/access_misc.result | 4 ++-- > test/sql/upgrade.result | 39 +++++++++++++++++++++++++++++++++++++-- > test/sql/upgrade.test.lua | 13 +++++++++++++ > 6 files changed, 83 insertions(+), 8 deletions(-) >