From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp21.mail.ru (smtp21.mail.ru [94.100.179.250])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 05203469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  8 May 2020 14:45:35 +0300 (MSK)
References: <20200508112105.31303-1-sergepetrenko@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <b5beb420-b6c8-09cf-d573-cd37586835f7@tarantool.org>
Date: Fri, 8 May 2020 14:45:34 +0300
MIME-Version: 1.0
In-Reply-To: <20200508112105.31303-1-sergepetrenko@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH] refactoring: sync declarations w/
	definitions
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tml <tarantool-patches@dev.tarantool.org>


08.05.2020 14:21, Serge Petrenko пишет:
> Commit b136a61e51ac871f32658b611d4ce7b7f7d5363c already fixed a similar
> problem with build failure on OS X, but later box_return_mp() and
> box_session_push() were exported, so their declarations and definitions
> also need to be synced.
> Add API_EXPORT attribute to the definitions of these functions.
>
> Follow-up #4885


Nevermind, I see it's already fixed in master.

> ---
> https://github.com/tarantool/tarantool/issues/4885
> https://github.com/tarantool/tarantool/tree/sp/fix-compiler-warn
>
>   src/box/box.cc | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/box/box.cc b/src/box/box.cc
> index ae0907e0f..909af0999 100644
> --- a/src/box/box.cc
> +++ b/src/box/box.cc
> @@ -1075,7 +1075,7 @@ box_return_tuple(box_function_ctx_t *ctx, box_tuple_t *tuple)
>   	return port_c_add_tuple(ctx->port, tuple);
>   }
>   
> -int
> +API_EXPORT int
>   box_return_mp(box_function_ctx_t *ctx, const char *mp, const char *mp_end)
>   {
>   	return port_c_add_mp(ctx->port, mp, mp_end);
> @@ -1461,7 +1461,7 @@ box_sequence_reset(uint32_t seq_id)
>   	return sequence_data_delete(seq_id);
>   }
>   
> -int
> +API_EXPORT int
>   box_session_push(const char *data, const char *data_end)
>   {
>   	struct session *session = current_session();

-- 
Serge Petrenko