From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1306D244BC
	for <tarantool-patches@freelists.org>; Wed, 16 May 2018 14:53:01 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id CD0BmgAmdLqP for <tarantool-patches@freelists.org>;
	Wed, 16 May 2018 14:53:01 -0400 (EDT)
Received: from smtp2.mail.ru (smtp2.mail.ru [94.100.179.91])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C24C223E13
	for <tarantool-patches@freelists.org>; Wed, 16 May 2018 14:53:00 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 1/1] sql: IS is only applicable when
 dealing with NULL
References: <1526478655.299515943@f491.i.mail.ru>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <b558d70e-4e45-b5bd-5b2d-b1faf9b207ba@tarantool.org>
Date: Wed, 16 May 2018 21:52:58 +0300
MIME-Version: 1.0
In-Reply-To: <1526478655.299515943@f491.i.mail.ru>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, =?UTF-8?B?0JzQtdGA0LPQtdC9INCY0LzQtdC1?= =?UTF-8?B?0LI=?= <imeevma@tarantool.org>

Hello. Thanks for the patch! See my 2 comments below.

On 16/05/2018 16:50, Мерген Имеев wrote:
> According to ANSI Standard IS/IS NOT can be used to determine
> if values is null. At the same time in SQLite3 IS/IS NOT have an
> additional function - it can be used to check equality of two
> values. This patch removes that additional function.
> 
> Closes #2136
> ---

1. Please, post here link to the branch and issue like this:
https://www.freelists.org/post/tarantool-patches/PATCH-11-vinyl-fix-crash-in-vinyl-iterator-secondary-next

2. You forgot to push you patch. I do not see a branch on github.