From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BDCF26EC5F; Tue, 20 Apr 2021 01:37:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BDCF26EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618871843; bh=CjrlG9Xp3w5reS0Qd4NUbWaqSfbn0BJz1VOGva38l4A=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=zvOrKS7/pGRmh7/tw5EA7KYMj/Yletp0Nmt+/1xj7SLi+qHRzadATof20JRjVAp6O /nFHk9stluVzkOmBJrG0sITF9vV6/kCH3m6Tw1RAfE+5dzFNsVip1quBVPNYsh9+j1 7+xthJAOV/fyFcVhGa9wkQB0kU5clQnOMt1WEXiA= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A44C96EC5F for ; Tue, 20 Apr 2021 01:37:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A44C96EC5F Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lYcVy-0001QP-Vk; Tue, 20 Apr 2021 01:37:11 +0300 To: Serge Petrenko , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: Message-ID: Date: Tue, 20 Apr 2021 00:37:10 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480EBD5CA77A668ECB87DA2124B0A8E6609182A05F53808504035A8E308C5767CCAEF7DC758675E762CD180BA83C7A7A4A23BC551BB082F55CB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73230F712CF4B3924EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372FCE560095E3DFB88638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2E53959D9AADEB1C9AE249E8C94F6C585CB2E3681EEBA4C9602ED4CEA229C1FA827C277FBC8AE2E8B7529912EAE4C333BA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3E3800B164E348C91117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BB07C9E286C61B7F975ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978319A5E66ACF10FF2892240D5316989BD39 X-C1DE0DAB: 0D63561A33F958A5F75EDB7DFC16C50BDB509C8D44F08BCAF56150A3464BF4BED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347324AA9FA07FF01E9AA7ED6C12F63BB13FC2D3A2C50DFE1246E2F41D79D018BCD3AABC78651956021D7E09C32AA3244C15D963EC47CF31074BDE9A2335933332259227199D06760AFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojocJA+pXcDunLmWDjSySRyw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638221846EFB41C2417CC44A5FADB671E44C03841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 00/12] raft: introduce manual elections and fix a bug with re-applying rolled back transactions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On top of the branch I made this: ==================== diff --git a/src/box/box.cc b/src/box/box.cc index 59925962d..b026dfe05 100644 --- a/src/box/box.cc +++ b/src/box/box.cc @@ -1582,16 +1582,21 @@ box_promote(void) */ if (box_election_mode == ELECTION_MODE_MANUAL) raft_stop_candidate(box_raft(), false); + else + assert(false); if (rc != 0) { + assert(false); in_promote = false; return -1; } if (!box_raft()->is_enabled) { + assert(false); diag_set(ClientError, ER_RAFT_DISABLED); in_promote = false; return -1; } if (box_raft()->state != RAFT_STATE_LEADER) { + assert(false); diag_set(ClientError, ER_INTERFERING_PROMOTE, box_raft()->leader); in_promote = false; ==================== And all the tests passed (except hanging election qsync stress, but it didn't crash). This means there are not enough tests. But I didn't have time to help adding any to cover this assertions yet.